Skip to content
Snippets Groups Projects

Resolve "Add signature test for identity and membership documents parsing"

Merged Resolve "Add signature test for identity and membership documents parsing"
32-add-signature-test-for-identity-and-membership-documents-parsing into dev
Merged nanocryk requested to merge 32-add-signature-test-for-identity-and-membership-documents-parsing into dev

Closes #32 (closed)

Edited by nanocryk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nanocryk added 2 commits

    added 2 commits

    • 3805a4ca - [enh] signatures test on parsed Identity document
    • a0b959a0 - [enh] signatures test on parsed Membership document

    Compare with previous version

  • nanocryk changed title from WIP: Resolve "Add signature test for identity and membership documents parsing" to Resolve "Add signature test for identity and membership documents parsing"

    changed title from WIP: Resolve "Add signature test for identity and membership documents parsing" to Resolve "Add signature test for identity and membership documents parsing"

  • nanocryk added 2 commits

    added 2 commits

    • 7be51abe - [enh] signatures test on parsed Identity document
    • ecda0ceb - [enh] signatures test on parsed Membership document

    Compare with previous version

  • nanocryk changed title from Resolve "Add signature test for identity and membership documents parsing" to WIP: Resolve "Add signature test for identity and membership documents parsing"

    changed title from Resolve "Add signature test for identity and membership documents parsing" to WIP: Resolve "Add signature test for identity and membership documents parsing"

  • nanocryk
    nanocryk @nanocryk ·
    Author Contributor

    @librelois J'ai ajouté le test, et j'ai corrigé la variable doc qui ne doit pas contenir la signature. Il faudrait que je rajoute les même tests sur le parseur supérieur, mais c'est moins un "test unitaire" du coup.

    Edited by nanocryk
  • nanocryk added 1 commit

    added 1 commit

    • 06ab5a0e - [fix] correct regexes to handle no line break after last signature

    Compare with previous version

  • nanocryk changed title from WIP: Resolve "Add signature test for identity and membership documents parsing" to Resolve "Add signature test for identity and membership documents parsing"

    changed title from WIP: Resolve "Add signature test for identity and membership documents parsing" to Resolve "Add signature test for identity and membership documents parsing"

  • nanocryk
    nanocryk @nanocryk ·
    Author Contributor

    review @librelois

  • Éloïs
    Éloïs @librelois ·
    Owner

    @nanocryk félicitations c'est dun bon boulot, je valide :)

    Il faudrait que je rajoute les même tests sur le parseur supérieur, mais c'est moins un "test unitaire" du coup.

    Oui la on rentre dans les tests d'intégration, on pourra peut etre voir çà plus tard, après si chaque parser de base a son test unitaire pour les signatures en principe on devrait être déjà bon ;)

  • nanocryk mentioned in commit 0b49e348

    mentioned in commit 0b49e348

  • nanocryk merged

    merged

Please register or sign in to reply