Skip to content
Snippets Groups Projects

Resolve "cli: keys modify: ask salt and password on password prompt for security"

Closes #201 (closed)

Edited by dvermd

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Éloïs
  • Éloïs
  • Éloïs
  • Éloïs
  • 261 stdin_mock.expect_get_password().returning(|prompt| {
    262 if prompt.starts_with("Salt:") {
    263 Ok(Secret {
    264 secret: SALT_TEST.to_owned(),
    265 })
    266 } else if prompt.starts_with("Password:") {
    267 Ok(Secret {
    268 secret: PASSWORD_TEST.to_owned(),
    269 })
    270 } else {
    271 Err(std::io::Error::new(
    272 std::io::ErrorKind::InvalidInput,
    273 format!("should not be called with {}", prompt),
    274 ))
    275 }
    276 });
  • @dvermd, Pense aux #[inline] sur les fonctions qui n'ont qu'une seule instruction :)

  • dvermd added 2 commits

    added 2 commits

    • a35e0def - wip1 sans les test
    • e174c4d5 - [ref] conf: refactor tests and improve readability

    Compare with previous version

  • dvermd added 1 commit

    added 1 commit

    • fc2d94ef - [ref] conf: refactor tests and improve readability

    Compare with previous version

  • @librelois la CI ne démarre pas, elle est marquée en skip. Par rapport à la dernière CI sur le commit e174c4d5 j'ai juste squashé 2 commits de refactor

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading