Resolve "Refractor wotb to have separate traits for WoT memory layout and WoT calculations."
Closes #43 (closed)
Merge request reports
Activity
added 1 commit
- 22d860e9 - [ref] get_path is now generic in a PathFinder trait
added 1 commit
- 932f478a - [ref] get_path is now generic find_paths in a PathFinder trait
added 1 commit
- 5cb493aa - [enh] constructor in trait to avoid using generators
added 40 commits
-
7f5830d6...56860f62 - 36 commits from branch
dev
- 0ddba421 - [ref] get_path is now generic find_paths in a PathFinder trait
- 8e17f1d2 - [enh] constructor in trait to avoid using generators
- 56eaa8ff - [ref] moved distance calculation in it's own trait, removed legacy distance calculation
- 6afba8be - [ref] separation in modules of wot data, path finding and distance calculations
Toggle commit list-
7f5830d6...56860f62 - 36 commits from branch
@librelois J'ai fait la séparation en trait, par contre je ne sais pas si on devrait passer par des fonctions statiques ou d'instance. Je penche plutot pour les instances, vu que les implémentation des traits pourraient avoir besoin d'informations supplémentaires, cependant ça alourdi un peu le code.
@nanocryk je préfère passer par des fonctions d'instances. Et oui pour refractor les tests dans une autre MR, tag moi quand tu aura finie celle ci ;)
added 12 commits
-
d4942e36...9f118a9a - 4 commits from branch
dev
- 34a10fec - [ref] get_path is now generic find_paths in a PathFinder trait
- 9ed01b05 - [enh] constructor in trait to avoid using generators
- c9589d22 - [ref] moved distance calculation in it's own trait, removed legacy distance calculation
- e5c178b4 - [ref] separation in modules of wot data, path finding and distance calculations
- 159b4e1e - [ref] Move from_file/to_file in its own trait.
- 97d02a85 - [ref] move all new traits in a new 'operations' module
- dd15daa5 - [ref] all operations functions take &self to allow configurations
- 19d4ca24 - [ref] update semver to provide alpha versions before stable release
Toggle commit list-
d4942e36...9f118a9a - 4 commits from branch
@librelois review ?
added 12 commits
-
19d4ca24...93d4012d - 4 commits from branch
dev
- c1f27f66 - [ref] get_path is now generic find_paths in a PathFinder trait
- d538323e - [enh] constructor in trait to avoid using generators
- 76de2ca8 - [ref] moved distance calculation in it's own trait, removed legacy distance calculation
- 357fc71a - [ref] separation in modules of wot data, path finding and distance calculations
- 31ac2be0 - [ref] Move from_file/to_file in its own trait.
- cb31751c - [ref] move all new traits in a new 'operations' module
- e03fa18d - [ref] all operations functions take &self to allow configurations
- b4bf19ac - [ref] update semver to provide alpha versions before stable release
Toggle commit list-
19d4ca24...93d4012d - 4 commits from branch
- wotb/operations/file.rs 0 → 100644
150 } else { 151 buffer_3b.push(byte); 152 if count_bytes % 3 == 2 { 153 let mut buf = &buffer_3b.clone()[..]; 154 let source = buf.read_u24::<BigEndian>().expect("fail to parse source"); 155 wot.add_link(NodeId(source as usize), NodeId((target - 1) as usize)); 156 remaining_links -= 1; 157 buffer_3b.clear(); 158 } 159 count_bytes += 1; 160 } 161 } 162 Ok((wot, file_pointing_to_blockstamp)) 163 } 164 165 /// Tru to write a `WebOfTrust` in a file. changed this line in version 10 of the diff
@librelois I applied the latest table fmt (via rustup) and only commited
wotb
formats, while warnings came from other crates outside of this MR scope.@nanocryk ok for fmt but please correct the comment typo ;)
@librelois done