Fix weight accounting

The problem is slightly different from the previously raised issue due to the deletion of instance pallets. Currently, the problem lies in having two tuple handlers (OnIdtyChange and Event). The weight of the function calling these handlers is the sum of each implementation. If these functions are not called in hooks, it will be possible to take the worst possible path as an approximation. However, some are called in on_initialize, and the worst case is close to 7% of a block, approximately 10 times the average path.

• Add weight return in OnIdtyChange and Event handlers.
• Account for the weight where these handlers are called.
• Replace all +=, -= by saturating_add and saturating_sub for consistency.
• Closes #163 (closed).
• Closes #203 (closed)

Note: Some handlers are difficult to benchmark using a benchmark function, so the accounting is performed by counting reads and writes, inspired by the staking pallet from Substrate.

Closes #167 (closed)

pallets/certification/src/lib.rs

@@ -342,7 +342,7 @@ pub mod pallet {
         pub fn do_remove_all_certs_received_by(idty_index: T::IdtyIndex) -> Weight {
             let mut weight = T::DbWeight::get().reads_writes(1, 0);
             for (issuer, _) in CertsByReceiver::<T>::get(idty_index) {
-                weight += Self::do_remove_cert(issuer, idty_index, None);
+                weight = weight.saturating_add(Self::do_remove_cert(issuer, idty_index, None));
             }
             weight
         }
@@ -366,17 +366,13 @@ pub mod pallet {
             if verify_rules {
                 // only verify internal rules if asked
                 if let Err(e) = Self::check_add_cert_internal(issuer, receiver, block_number) {
-                    sp_std::if_std! {
-                        println!("fail to force add cert: {:?}", e)
-                    }
+                    sp_std::if_std! {println!("fail to force add cert: {:?}", e)}
                     return T::WeightInfo::do_add_cert_checked();
                 }
             }
 
             if let Err(e) = Self::try_add_cert(block_number, issuer, receiver) {
-                sp_std::if_std! {
-                            println!("fail to force add cert: {:?}", e)
-                }
+                sp_std::if_std! {println!("fail to force add cert: {:?}", e)}
             }
             T::WeightInfo::do_add_cert_checked()
         }
@@ -469,15 +465,18 @@ pub mod pallet {
         // (run at on_initialize step)
         fn prune_certifications(block_number: BlockNumberFor<T>) -> Weight {
             // See on initialize for the overhead weight accounting
-            let mut total_weight = Weight::zero();
+            let mut weight = Weight::zero();
 
             if let Some(certs) = CertsRemovableOn::<T>::take(block_number) {
                 for (issuer, receiver) in certs {
-                    total_weight += Self::do_remove_cert(issuer, receiver, Some(block_number));
+                    weight = weight.saturating_add(Self::do_remove_cert(
+                        issuer,
+                        receiver,
+                        Some(block_number),
+                    ));
                 }
             }
-
-            total_weight
+            weight
         }
 
         /// perform the certification removal
@@ -527,7 +526,6 @@ pub mod pallet {
                     receiver,
                     expiration: block_number_opt.is_some(),
                 });
-                // Should always return Weight::zero
                 T::OnRemovedCert::on_removed_cert(
                     issuer,
                     issuer_issued_count,