IIndexDAO: Rename searchByPubkey() into getOldFromPubkey(), and simplify signature

SqliteIIndex: Apply a reduce() inside getOldFromPubkey() (+ add an ORDER BY)
IdentityDAL: rename getFromPubkey() into findByPub() as it return an array
FileDAL: simplify searchJustIdentitiesByPubkey()

app/lib/dal/fileDAL.ts

@@ -933,11 +933,9 @@ export class FileDAL implements ServerDAO {
   }
 
   async searchJustIdentitiesByPubkey(pubkey: string): Promise<DBIdentity[]> {
-    const pendings = await this.idtyDAL.getFromPubkey(pubkey);
-    const writtens = await this.iindexDAL.searchByPubkey(pubkey);
-    const nonPendings = Underscore.filter(writtens, (w: IindexEntry) => {
-      return Underscore.where(pendings, { pubkey: w.pub }).length == 0;
-    });
+    const pendings = await this.idtyDAL.findByPub(pubkey);
+    const writtenIdty = await this.iindexDAL.getOldFromPubkey(pubkey);
+    const nonPendings = writtenIdty && Underscore.where(pendings, { pubkey: writtenIdty.pub }).length === 0 ? [writtenIdty] : [];
     const found = pendings.concat(
       nonPendings.map((i: any) => {
         // Use the correct field

app/lib/dal/indexDAL/abstract/IIndexDAO.ts

@@ -19,7 +19,7 @@ export interface IIndexDAO extends ReduceableDAO<IindexEntry> {
 
   searchThoseMatching(search: string): Promise<OldIindexEntry[]>;
 
-  searchByPubkey(search: string): Promise<OldIindexEntry[]>;
+  getOldFromPubkey(search: string): Promise<OldIindexEntry | null>;
 
   getFullFromUID(uid: string): Promise<FullIindexEntry>;
 

app/lib/dal/indexDAL/leveldb/LevelDBIindex.ts

@@ -281,13 +281,11 @@ export class LevelDBIindex extends LevelDBTable<IindexEntry[]>
       .concat(pubIdentities.filter((p) => p.pub));
   }
 
-  async searchByPubkey(pub: string): Promise<OldIindexEntry[]> {
+  async getOldFromPubkey(pub: string): Promise<OldIindexEntry | null> {
     const identities = await this.findByPub(pub);
     if (!identities.length) {
-      return [];
+      return null;
     }
-    // TODO Why do we need to use reduce() on array ? This will merge items into one object
-    const mergedIdentities = OldTransformers.toOldIindexEntry(reduce(identities))
-    return [mergedIdentities];
+    return OldTransformers.toOldIindexEntry(reduce(identities));
   }
 }

app/lib/dal/indexDAL/sqlite/SqliteIIndex.ts

-import { FullIindexEntry, IindexEntry, Indexer } from "../../../indexer";
+import {FullIindexEntry, IindexEntry, Indexer, reduce} from "../../../indexer";
 import { SQLiteDriver } from "../../drivers/SQLiteDriver";
 import { MonitorExecutionTime } from "../../../debug/MonitorExecutionTime";
 import { IIndexDAO } from "../abstract/IIndexDAO";
@@ -212,6 +212,15 @@ export class SqliteIIndex extends SqliteTable<IindexEntry>
     return (await this.getFromUID(uid)) as FullIindexEntry;
   }
 
+  @MonitorExecutionTime()
+  async getOldFromPubkey(pub: string): Promise<OldIindexEntry | null> {
+    const identities = await this.find("SELECT * FROM iindex WHERE pub = ? order by writtenOn ASC", [pub]);
+    if (!identities.length) {
+      return null;
+    }
+    return OldTransformers.toOldIindexEntry(reduce(identities));
+  }
+
   @MonitorExecutionTime()
   async getMembers(): Promise<{ pubkey: string; uid: string | null }[]> {
     const members = await this.find(
@@ -263,14 +272,4 @@ export class SqliteIIndex extends SqliteTable<IindexEntry>
       ])
     ).map(OldTransformers.toOldIindexEntry);
   }
-
-  @MonitorExecutionTime()
-  async searchByPubkey(pub: string): Promise<OldIindexEntry[]> {
-    // TODO Why not need reduce() here ? As done in the LevelDB implementation
-    return (
-        await this.find("SELECT * FROM iindex WHERE pub = ?", [
-          pub
-        ])
-    ).map(OldTransformers.toOldIindexEntry);
-  }
 }

app/lib/dal/sqliteDAL/IdentityDAL.ts

@@ -328,8 +328,8 @@ export class IdentityDAL extends AbstractSQLite<DBIdentity> {
     });
   }
 
-  getFromPubkey(pubkey: string) {
-    return this.sqlFind({pubkey});
+  findByPub(pub: string) {
+    return this.sqlFind({pubkey: pub});
   }
 
   async trimExpiredIdentities(medianTime: number) {