Skip to content
Snippets Groups Projects

Error: command plug is breaking by node 8

    • Closed Issue created by Éloïs @librelois

    I can't execute branch 1.6 (commit 9989856c) after use the plug command

    $ bin/duniter direct_start
module.js:538
    throw err;
    ^

Error: Cannot find module 'co'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/elois/dev/duniter/bin/duniter:4:12)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    Edited
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      It's work perfectly when i revert commit 96e1434a (branch fix/1.6)

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      @nodes/typescript members, please can you try to execute 1.6 branch at your home ?

    • Éloïs changed the description

      changed the description

    • nanocryk
      nanocryk @nanocryk ·

      Still can't run test completely : https://pastebin.com/khEAhKjU

    • Cédric Moreau
      Cédric Moreau @c-geek ·
      Owner

      Just pulled the 1.6 branch, ran:

      node -v
v8.9.1

      Then

      yarn
yarn test

  703 passing (1m)

Done in 93.61s.
    • Cédric Moreau
      Cédric Moreau @c-geek ·
      Owner

      @nanocryk Please shutdown the nodes on your machine before running tests :-)

    • nanocryk
      nanocryk @nanocryk · 
      702 passing (7m)
  1 failing

  1) WS2P server limitations should connect to s3 because of configuration favorism:
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at Timeout.<anonymous> (/home/nanocryk/downloads/duniter/node_modules/mocha/lib/runnable.js:232:19)
      at ontimeout (timers.js:475:11)
      at tryOnTimeout (timers.js:310:5)
      at Timer.listOnTimeout (timers.js:270:5)



error Command failed with exit code 1.
    • Cédric Moreau
      Cédric Moreau @c-geek ·
      Owner

      Oui alors celui-là c'est notre bête noire :-)

      Je viens de pousser un correctif, à la fois sur le test et sur le code sous-jacent qui tantôt appliquait la limitation, et à tel autre moment non.

      Je pense que tous les tests devraient passer désormais.

    • Cédric Moreau
      Cédric Moreau @c-geek ·
      Owner

      D'ailleurs j'ai la preuve, la CI est passée : https://git.duniter.org/nodes/typescript/duniter/pipelines/348

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      @c-geek l'erreur persiste, elle survient lorsque j'installe duniter-ui, toujours impossible de faire fonctionner la branche 1.6 pour moi, donc impossible de livrer...

      les tests passent mais svp essayez **d'éxécuter duniter ** via direct_start ou direct_web_start

    • Éloïs added W-urgent T-bug labels

      added W-urgent T-bug labels

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      @c-geek Je précise : tout fonctionne parfaitement bien sans duniter-ui, pour reproduire le bug il faut plugger duniter-ui puis tenter de lancer le noeud, et alors même un direct_start plante et donne :

      Edited by Éloïs
    • Éloïs added move to duniter-ui label

      added move to duniter-ui label

    • Éloïs changed title from Error: Cannot find module 'co' to Error: Cannot find module 'co' (when duniter-ui is plugged)

      changed title from Error: Cannot find module 'co' to Error: Cannot find module 'co' (when duniter-ui is plugged)

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      It seems to work if I use yarn add instead of duniter plug

    • Éloïs changed title from Error: Cannot find module 'co' (when duniter-ui is plugged) to Error: command plug is breaking by node 8

      changed title from Error: Cannot find module 'co' (when duniter-ui is plugged) to Error: command plug is breaking by node 8

    • Éloïs changed the description

      changed the description

    • Éloïs
      Éloïs @librelois ·
      Author Owner

      @c-geek I've pinpointed more precisely the origin of the problem, it's the plug command that breaks duniter, impossible to run duniter after executing the plug command, I can reproduce the problem every time and on several different machines!
      In addition, the problem comes from the transition to node 8.

      Edited by Éloïs
    • Éloïs
      Éloïs @librelois ·
      Author Owner

      The plug command seems to uninstall important elements :

      $ bin/duniter plug duniter-ui@1.6.x
Trying to install module "duniter-ui@1.6.x"...
true true
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/rimraf as it wasn't installed by /home/elois/dev/duniter/node_modules/rimraf
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/.bin/semver as it wasn't installed by /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/semver
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/.bin/rimraf as it wasn't installed by /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/rimraf
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/.bin/rc as it wasn't installed by /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/rc
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/.bin/nopt as it wasn't installed by /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/nopt
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/.bin/mkdirp as it wasn't installed by /home/elois/dev/duniter/node_modules/wotb/node_modules/node-pre-gyp/node_modules/mkdirp
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/rc as it wasn't installed by /home/elois/dev/duniter/node_modules/rc
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/eslint/node_modules/.bin/js-yaml as it wasn't installed by /home/elois/dev/duniter/node_modules/eslint/node_modules/js-yaml
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/semver as it wasn't installed by /home/elois/dev/duniter/node_modules/semver
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/.bin/node-pre-gyp as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/.bin/semver as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/semver
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/.bin/rimraf as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/rimraf
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/.bin/rc as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/rc
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/.bin/nopt as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/nopt
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/.bin/mkdirp as it wasn't installed by /home/elois/dev/duniter/node_modules/scryptb/node_modules/node-pre-gyp/node_modules/mkdirp
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/q-io/node_modules/.bin/mime as it wasn't installed by /home/elois/dev/duniter/node_modules/q-io/node_modules/mime
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/nopt as it wasn't installed by /home/elois/dev/duniter/node_modules/nopt
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/nyc/node_modules/.bin/rimraf as it wasn't installed by /home/elois/dev/duniter/node_modules/nyc/node_modules/rimraf
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/nyc/node_modules/.bin/mkdirp as it wasn't installed by /home/elois/dev/duniter/node_modules/nyc/node_modules/mkdirp
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/node-pre-gyp/node_modules/.bin/rc as it wasn't installed by /home/elois/dev/duniter/node_modules/node-pre-gyp/node_modules/rc
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/node-pre-gyp/node_modules/.bin/nopt as it wasn't installed by /home/elois/dev/duniter/node_modules/node-pre-gyp/node_modules/nopt
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/esparse as it wasn't installed by /home/elois/dev/duniter/node_modules/esprima
npm WARN gentlyRm not removing /home/elois/dev/duniter/node_modules/.bin/esvalidate as it wasn't installed by /home/elois/dev/duniter/node_modules/esprima
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN duniter-ui@1.6.30 requires a peer of duniter@1.6.x but none is installed. You must install peer dependencies yourself.
npm WARN request-promise-core@1.1.1 requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.
npm WARN The package sha1 is included as both a dev and production dependency.

+ duniter-ui@1.6.30
added 34 packages, removed 1340 packages, updated 161 packages and moved 3 packages in 21.817s
Module successfully installed.
    • Cédric Moreau mentioned in issue #689 (closed)

      mentioned in issue #689 (closed)

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply