Add "enp0s3" in the priority list of network interfaces

Note: I don't know at all what is this interface name ... is it a local one? private network?

Here is the faulty code: https://github.com/duniter/duniter/blob/master/app/lib/system/network.js#L303-L315

See http://blog.devarieux.net/2015/08/comprendre-la-prediction-de-noms-des-interfaces-reseau-de-systemd/

Also http://p3ter.fr/debian-ubuntu-eth0-c-est-fini.html

@M5oul si tu te sens d'attaque ... hésites pas ! En plus tu sais faire des préversions, ça peut aider Jean_F à avoir son noeud qui tourne !

Created by: M5oul

Ok, je regarde ça plus tard.

Created by: M5oul

So, it could exist many network interfaces names with this new conventions:

"ethernet network peripheral # serial #"

I found:

• with ethernet interfaces enp<#>s<#>[f<#>] as general form:
  • enp3s0f1 (on my Fedora instance)
  • enp0s3 (on upper links)
  • enp3s0 (on upper links)
• with Wi-Fi interfaces wlp<#>s<#> as general form:
  • wlp2s0 (on my Fedora instance)
  • wlp4s1 (on upper links)

It seems it could take many values.

I could temporally add them.

How could we match them all?

Created by: modulix

I guess that a good start should be to use list given by : $ ip link show

Created by: M5oul

Yep, we could also found them with ifconfig command.

Created by: modulix

For me, the best way to find the best interface to use is to get it by routing: $ ip route | grep ^default | awk '{print $5}' (no need to know which name it have)

In these lines of code dedicated to our issue, you can match them all by adding 2 regexps like:

if (entry.name.match(/^enp\ds\d/))  return 0;
if (entry.name.match(/^wlp\ds\d/))  return 1;

But to find the prefered one, maybe you need specific OS commands.

You also have Node.js documentation about network interfaces.

Created by: modulix

I was looking on https://www.npmjs.com/package/network but your regex sound good... it seems to be a very good solution.

We also have to handle Windows interfaces! I discovered it today with #573 (closed). I hope MacOS is just like Linux on this side.

Created by: M5oul

$ ip route | grep ^default | awk '{print $5}'

This command return nothing on my Fedora instance. Not sure it would be easy to found an universal shell command which could easily grep this network interface name.

The best way would be to match them all with a JavaScript regex.

Created by: modulix

$ ip route | grep ^default | awk '{print $5}' This command return nothing on my Fedora instance.

Sorry, it was not a real proposition of code to use, but more to show the logic i use to obtain interface name. Start from the routing table and select default gateway to get interface name... But it's much more complicated to do that in js! For now, the regex seems very good ;-)

Just tested on my Ubuntu 16.04, works like a charm