Feature/es8

Turns on the exclusive usage of NodeJS 8 for Duniter.

NwJS has been upgraded to 0.24.4 for this purpose, and Duniter no more allows the usage of NodeJS 6.

I've already tested these 3 artifacts:

• duniter-desktop for Linux (.tar.gz, .deb)
• duniter-desktop for Windows (.exe)
• duniter-server for ARM

Everything works fine, I could synchronize and join the network.

I've also introduced a new building feature to create testing artifacts:

./release/scripts/build.sh make deb

This command will build Linux (.tar.gz, .deb) locally with YEARMONTHDAY.HOURMINUTE.SECONDS version name. One can also use:

./release/scripts/build.sh make win
./release/scripts/build.sh make arm

Or the generic version which builds all 3 at once:

./release/new_prerelease.sh

If no tag is given to new_prerelease.sh, then it makes a local build. No artifact will be uploaded to GitHub.

You can see I've added a 0.24.4_common.gypi file for both Linux and Windows builds. That a fix for nw-gyp, which is bugged and without this file (which is the good one), we could not build NodeJS Addons properly and Duniter could not run. Once we will migrate to NodeJS 10, we will be able to remove these 2 files.

assigned to @nanocryk

assigned to @Insoleet

assigned to @moul

assigned to @librelois

assigned to @c-geek

Je propose d'intégrer cette MR demain, sauf mention contraire de l'un d'entre vous.

it's ok for me

All tests pass except one but I think the problem comes from my environment :

702 passing (2m)
  1 failing

  1) Linting eslint should have no errors in app:
     Error: TypeError: Cannot read property 'length' of undefined
      at Context.<anonymous> (/home/duniter/duniter/node_modules/mocha-eslint/index.js:14:13)
      at callFn (/home/duniter/duniter/node_modules/mocha/lib/runnable.js:348:21)
      at Test.Runnable.run (/home/duniter/duniter/node_modules/mocha/lib/runnable.js:340:7)
      at Runner.runTest (/home/duniter/duniter/node_modules/mocha/lib/runner.js:443:10)
      at /home/duniter/duniter/node_modules/mocha/lib/runner.js:549:12
      at next (/home/duniter/duniter/node_modules/mocha/lib/runner.js:361:14)
      at /home/duniter/duniter/node_modules/mocha/lib/runner.js:371:7
      at next (/home/duniter/duniter/node_modules/mocha/lib/runner.js:295:14)
      at Immediate.<anonymous> (/home/duniter/duniter/node_modules/mocha/lib/runner.js:339:5)
      at runCallback (timers.js:789:20)
      at tryOnImmediate (timers.js:751:5)
      at processImmediate [as _immediateCallback] (timers.js:722:5)

Mise à part le script batch qu'il aurait ptet fallu migrer en powershell (parce que le batch c'est quand même affreux comme langage), ok pour moi.

@Insoleet Ce n'était pas l'objet de la feature ici, toutefois tu peux le faire dans une autre branche. Personnellement je ne vais pas m'en occuper, c'est vraiment lourd !

mentioned in commit 184a65b2

merged