Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • duniter duniter
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 190
    • Issues 190
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nodes
  • typescript
  • duniterduniter
  • Merge requests
  • !1228

Merged
Created Dec 23, 2017 by Cédric Moreau@c-geekOwner

1.6 fix 1234

  • Overview 9
  • Commits 2
  • Pipelines 3
  • Changes 5

Okay, I'm happy to present you an official fix for issue #1234 (closed) that should definitely fix the problems that both @librelois and @moul could have encoutered in the past with PoW.

To sum up, this fix:

  • wraps proof.ts code in a function, to avoid global conflicts
  • move specific worker code into a new class PowWorker
  • systematically synchronize all the workers for any task: if a proof is asked, then the answer is not immediately returned to the program but will first wait for other workers to have cancelled their own proof. If a cancel is triggered, same idea: the code will wait all the workers to have cancelled before returning null as proof result.

I hope you will enjoy this new version, I also tested it on Ğ1 network with more than 10 blocks long. It just works.

Happy testing :)

Edited Jan 06, 2018 by Éloïs
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1.6_fix_1234