Skip to content
Snippets Groups Projects

Migrate to NodeJS 9

Merged Éloïs requested to merge fix/gitlab/1270 into 1.6
Edited by Éloïs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2 2 "name": "duniter",
3 3 "version": "1.6.17",
4 4 "engines": {
5 "node": ">=8.2.1 <9",
5 "node": ">=8.2.1 <10",
  • I think you can let pass Node.js v10 here as when it will be released, developers will still be able to install v10. v10 should be the stable release of v9. It's that important, this point shouldn't block you to merge this commit.

  • Please register or sign in to reply
  • Éloïs added 1 commit

    added 1 commit

    • e1a3a2ec - [fix] duniter cli requires node v9 rather than v8

    Compare with previous version

  • Moul
    Moul @moul started a thread on commit e1a3a2ec
  • 35 35
    36 36 VERSION=`$NODE -v`
    37 37
    38 if [[ $VERSION != v8* ]]; then
    39 echo "$NODE v8 is required";
    38 if [[ $VERSION != v9* ]]; then
  • Éloïs added 1 commit

    added 1 commit

    Compare with previous version

  • Éloïs mentioned in commit ec1189e2

    mentioned in commit ec1189e2

  • merged

  • Please register or sign in to reply
    Loading