Skip to content
Snippets Groups Projects

#1426: Allow a wider range of Node.js versions and document dependencies to build

Closed #1426: Allow a wider range of Node.js versions and document dependencies to build
1 unresolved thread
Closed Moul requested to merge 1426_allow_wider_node_vers into dev
1 unresolved thread

  • Doc: Add precision to install gcc-c++ for Fedora

Close #1426 (closed).

Merge request reports

Checking pipeline status.

Approval is optional

Closed by ÉloïsÉloïs 4 years ago (May 17, 2021 10:25am UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
54 57
55 58 if !args.skip_npm {
56 59 println!("Check node version …");
57 if exec_and_get_stdout(Command::new("node").arg("-v"))
58 .unwrap_or_default()
59 .trim_end()
60 != format!("v{}", NODE_VERSION)
61 {
60 let node_vers = exec_and_get_stdout(Command::new("node").arg("-v")).unwrap_or_default();
61 let node_vers = node_vers.trim_end();
  • Author Owner

    I had to do this additional step to trim the content, as doing it at line 60, I encounter a free issue, I do not know how to fix.

  • Please register or sign in to reply
  • @moul gitlab bug je ne peut pas voir les change dans gitlab, or j'ai des remarques que je veut ajouter depuis hier. Je vais essayer de suppirmer et recréer la MR, et si ça ne résout pas le problème je te donnerai mes remarques à la main avec les numéro de ligne :/

  • closed

  • Please register or sign in to reply
    Loading