fix(sync): don't lose nodes on single download err

This is a cherry-pick of commit 7a59f46f from branch dev. This should help with synchronizing.

P2pCandidate.dlPromise promise doesn't resolve on download errors such as socket timeouts. Each time such an error occurs, the node is lost for the sync because the 'this.dlPromise.isResolved()' check used for testing the node's availability never succeeds anymore for this node.

This patch hardens the blocks downloading in two ways:

• Retrying the download up to 5 times when the number of returned blocks is different from what was requested
• On failure returns an empty block array so that the dlPromise is resolved and the node failure could be handled as expected at the P2PSyncDownloader level triggering the P2pCandidate.addFailure() function.

requested review from @c-geek

approved this merge request

You get my approval but I didn't really read and tested the code.

It's just that I can't control everything and at some point I prefer to trust you. Also, you pointed that this commit is already on dev and seems to work, so it makes me comfortable.

added 29 commits

• f4af8f4d...8ef61d86 - 28 commits from branch release/1.8
• 5fb7f030 - fix(sync): don't lose nodes on single download err

Compare with previous version

This commit was already cherry-picked . Closing the MR.

closed