#135, #162: Introduce mypy, pylint, isort, gitlab-ci pre-commit hooks

• Add mypy pre-commit hook
• Introduce isort pre-commit hook
• Sort imports in every files
• Fix cyclic import issue in ascii_armor
• Add isort job
• Introduce gitlab-ci-linter pre-commit hook
• Move pylint rules from the Makefile to the pyproject.toml
• Introduce pylint pre-commit hook
• Change pre-commit hooks documentation
• Run lint job with pylint from the image
• Run checks by calling directly the tools without the makefile

Close #135 (closed), #162 (closed).

changed milestone to %1.0.0

added CI/CD Dep Dev Env Doc/Website labels

added 3 commits

• 0a126c64 - [doc] #162 (closed): Document the pre-commit hooks in use
• b6e5d2f5 - [ci] try pylint job with pylint from the image
• d4e8df33 - pylint: try without E0401

Compare with previous version

changed the description

added enhancement label

added 2 commits

• 1457ec10 - [ci] Run lint job with pylint from the image
• e69733b0 - [ci] Run checks by calling directly the tools without the makefile

Compare with previous version

changed the description

added 7 commits

• 22bd5b26 - [ci] #162 (closed): Add isort job
• 753749c4 - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• eeaff652 - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• 7854dea9 - [enh] #162 (closed): Introduce pylint pre-commit hook
• fef94722 - [doc] #162 (closed): Document the pre-commit hooks in use
• 279eceb7 - [ci] Run lint job with pylint from the image
• 4bbcef90 - [ci] Run checks by calling directly the tools without the makefile

Compare with previous version

added 3 commits

• 6d886651 - [doc] #162 (closed): Document the pre-commit hooks in use
• 8457bd59 - [ci] Run lint job with pylint from the image
• 5a3e0d39 - [ci] Run checks by calling directly the tools without the makefile

Compare with previous version

marked this merge request as ready

assigned to @vtexier and unassigned @moul

requested review from @vtexier

added 12 commits

• 8bd2961c - [enh] #162 (closed): Add mypy pre-commit hook
• 389bed2c - [enh] #162 (closed): Introduce isort dep and pre-commit hook
• 5f356f52 - [enh] #162 (closed): sort imports in every files
• a2c45fda - [fix] #162 (closed): Fix cyclic import issue in ascii_armor
• 0f25a746 - [mod] #162 (closed): Add make isort rule
• 880726d9 - [ci] #162 (closed): Add isort job
• 9cb5612f - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• 9107a8b1 - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• cb823af4 - [enh] #162 (closed): Introduce pylint pre-commit hook
• 30f9fb2e - [doc] #162 (closed): Document the pre-commit hooks in use
• 6c5b5603 - [ci] Run lint job with pylint from the image
• b0b20fab - [ci] Run checks by calling directly the tools without the makefile

Compare with previous version

approved this merge request

Great job! Thanks, you can merge!

added 21 commits

• b0b20fab...7ce7e3b7 - 9 commits from branch dev
• 5a6744f9 - [enh] #162 (closed): Add mypy pre-commit hook
• 73ca855d - [enh] #162 (closed): Introduce isort dep and pre-commit hook
• fc946905 - [enh] #162 (closed): sort imports in every files
• f07d5306 - [fix] #162 (closed): Fix cyclic import issue in ascii_armor
• 98c79d32 - [mod] #162 (closed): Add make isort rule
• 34233df8 - [ci] #162 (closed): Add isort job
• 77be0233 - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• 4b4f363a - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• 734dbdc7 - [enh] #162 (closed): Introduce pylint pre-commit hook
• 8bee61d5 - [doc] #162 (closed): Document the pre-commit hooks in use
• c1c072bc - [ci] Run lint job with pylint from the image
• 843e2a2c - [ci] Run checks by calling directly the tools without the makefile

Compare with previous version

changed the description

changed the description

I rework a bit my changes. I removed isort dependency from pyproject.toml and remove the make rule, since we are duplicating the dev dependencies in Poetry and Pre-commit virtualenvs. I decided to go this way: getting rid of the makefile in favour of pre-commit hooks. cf #165 (closed).

Can you review it once more?

added 13 commits

• c1aad5cd - 1 commit from branch dev
• 20ec4f57 - [enh] #162 (closed): Introudce mypy pre-commit hook
• f4e6fe14 - [enh] #162 (closed): Introduce isort pre-commit hook
• 75ac7d23 - [enh] #162 (closed): sort imports in every files
• 3683ec09 - [fix] #162 (closed): Fix cyclic import issue in ascii_armor
• 5155ddd9 - [ci] #162 (closed): Add isort job
• 94e7d20d - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• 3fd7cdc5 - [enh] #162 (closed): Introduce pylint pre-commit hook
• 8a236a39 - [lint] #162 (closed): Define classmethod
• caf2dbe7 - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• d8ff1c71 - [doc] #162 (closed), #165 (closed): Change pre-commit hooks documentation
• ce80ffba - [ci] Run lint job with pylint from the image
• ad2612b6 - [ci] #165 (closed): Run checks by calling directly the tools without the makefile

Compare with previous version

added 10 commits

• ffa385a6 - [enh] #162 (closed): sort imports in every files
• 9f4dfaa8 - [fix] #162 (closed): Fix cyclic import issue in ascii_armor
• 31e8d840 - [ci] #162 (closed): Add isort job
• 70912e56 - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• 6caa1771 - [enh] #162 (closed): Introduce pylint pre-commit hook
• e163698c - [lint] #162 (closed): Define classmethod
• bbf70a20 - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• 4ce02207 - [doc] #162 (closed), #165 (closed): Change pre-commit hooks documentation
• 872b47b9 - [ci] Run lint job with pylint from the image
• c398fb47 - [ci] #165 (closed): Run checks by calling directly the tools without the makefile

Compare with previous version

I need to see how it integrate within the Pycharm workflow. Because I fear to not see exactly what goes wrong in a hook in Pycharm, rather than the make command in the terminal. I see that Pre-commit commands ran manually are more complex than make commands (options needed). And it worries me.

added 5 commits

• 6030a80b - [lint] #162 (closed): Define staticmethod
• 33b78815 - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• d1dcfb87 - [doc] #162 (closed), #165 (closed): Change pre-commit hooks documentation
• 7d34f8f3 - [ci] Run lint job with pylint from the image
• 3ae5e157 - [ci] #165 (closed): Run checks by calling directly the tools without the makefile

Compare with previous version

Let's discuss this in #165 (closed). I answered there.

mentioned in issue #165 (closed)

added 1 commit

• 7f99e27e - [ci] Update to newest syntax

Compare with previous version

added 17 commits

• 3ae5e157...8103b704 - 5 commits from branch dev
• cb571987 - [enh] #162 (closed): Introudce mypy pre-commit hook
• 6adea371 - [enh] #162 (closed): Introduce isort pre-commit hook
• bb856c9a - [enh] #162 (closed): sort imports in every files
• b7309c88 - [fix] #162 (closed): Fix cyclic import issue in ascii_armor
• 448f8ade - [ci] #162 (closed): Add isort job
• f2c670bf - [mod] #135 (closed): Move pylint rules from the Makefile to the pyproject.toml
• c6346b58 - [enh] #162 (closed): Introduce pylint pre-commit hook
• 02add38e - [lint] #162 (closed): Define staticmethod
• 45b67d1c - [enh] #162 (closed): Introduce gitlab-ci-linter pre-commit hook
• 5a32d9c1 - [doc] #162 (closed), #165 (closed): Change pre-commit hooks documentation
• baab6cd0 - [ci] Run lint job with pylint from the image
• 0719b34c - [ci] #165 (closed): Run checks by calling directly the tools without the makefile

Compare with previous version

resolved all threads

May I merge this one? Since I am not sure since the threads discussions. Just to make sure.

Yes you can.

merged

This morning, command pre-commit run -a failed on .gitlab-ci.yml linter step:

.gitlab-ci.yml linter....................................................Failed
- hook id: gitlab-ci-linter
- exit code: 1

[debug] server: https://git.duniter.org
[debug] project: None
[debug] insecure: False
[debug] filename: .gitlab-ci.yml
Server said HTTP Error 401: Unauthorized: https://git.duniter.org/api/v4/ci/lint

[EDIT] In fact I can not connect to gitlab anymore since this morning! push failed...