[fix] Partial revert of previous revocation changes

To be compatible with mypy, pylint, pytest
Returning in case of dry-run
Not returning a value since mypy and pylint complain
that every parts of the functions should return an integer

silkaj/revocation.py

@@ -54,6 +54,7 @@ def save(ctx: click.Context, file: str) -> None:
 
     if ctx.obj["DRY_RUN"]:
         click.echo(rev_doc.signed_raw())
+        return
 
     idty_table = idty_tools.display_identity(rev_doc.identity)
     click.echo(idty_table.draw())
@@ -85,6 +86,7 @@ def revoke_now(ctx: click.Context) -> None:
 
     if ctx.obj["DRY_RUN"]:
         click.echo(rev_doc.signed_raw())
+        return
 
     idty_table = idty_tools.display_identity(rev_doc.identity)
     click.echo(idty_table.draw())
@@ -110,6 +112,7 @@ def verify(ctx: click.Context, file: str) -> None:
 
     if ctx.obj["DRY_RUN"]:
         click.echo(rev_doc.signed_raw())
+        return
 
     idty_table = idty_tools.display_identity(rev_doc.identity)
     click.echo(idty_table.draw())
@@ -136,6 +139,7 @@ def publish(ctx: click.Context, file: str) -> None:
     rev_doc = verify_document(file)
     if ctx.obj["DRY_RUN"]:
         click.echo(rev_doc.signed_raw())
+        return
 
     idty_table = idty_tools.display_identity(rev_doc.identity)
     click.echo(idty_table.draw())

tests/test_revocation.py

@@ -367,9 +367,10 @@ def test_revocation_cli_save(display, dry_run, file, user_input, expected, monke
             "",
             [
                 "Version: 10",
+            ],
+            [
                 "Revocation document is valid.\n",
             ],
-            [],
         ),
         (
             False,