Add ability to unlock and lock transaction with XHX, CSV, CLTV conditions

changed the description

changed title from Add ability to send transaction with unlock conditions to Add ability to send transaction with XHX, CSV, CLTV unlock conditions

changed the description

mentioned in issue #143 (closed)

changed the description

mentioned in issue #231 (closed)

This issue deals with spending sources with lock conditions, right ? Not with sending transactions with lock conditions ?

Or both ?

For unlocking sources, I think we should :

create a "unlock" feature that sends all possible sources locked with CSV(), CLTV(), XHX() to the account, with the only SIG() condition.
modify the source selection algorithm so that CSV() and CLTV() are used as early as possible.

For sending locked outputs, I thinl we should create a "lock" feature, with sub-options :

"--password PASSWORD",
"--date YY-MM-DD-HH:MM",
"--delay NUMBER:hour/day/month/year" with default on days.

changed title from Add ability to send transaction with XHX, CSV, CLTV unlock conditions to Add ability to unlock and lock transaction with XHX, CSV, CLTV conditions

changed the description

"unlock" feature is live on branch unlock_conditions. It handles complex conditions for one issuer, with CSV, CLTV, XHX unlocks. Feel free to test.

silkaj unlock silkaj -y unlock silkaj unlock --passwords 007:421:12

XHX should be only integers.

There is still work to be done on the display, but it works. Available CSV and CLTV sources are automatically handled on normal transactions.

However, I think we should modify the "balance" display : if there are locked sources on the account, the display should look like :

Blockchain:
-----------
Relative     = 0.73 UD ĞTest
Quantitative = 2100.0 ĞTest

Pending Transaction:
--------------------
Relative     = 0.48 UD ĞTest
Quantitative = 1400.0 ĞTest

Locked amount :
---------------
Relative    = 1 UD ĞTest
Quantitative= X ĞTest

Available amount :
------------------
Relative    =
Quantitative=

Total amount of: 3i7jBZz1bYVTtao3C6e7cN21JHYjHCDR9pKeReE4rdVe
-------------------------------------------------------------
Total Relative     = 1.21 UD ĞTest
Total Quantitative = 3500.0 ĞTest
Total Relative to average money share = 0.01 × M/N
Total Relative to monetary mass       = 0.082 % M

For lightness and consistency with the transaction_confirmation() display, it might also be :

╒══════════════════════════════╤══════════════════════════════════════════════╕
| Available balance            | 1000.0 ĞTest | 0.48 UD ĞTest                 |
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Blockchain                   │ 900.0 ĞTest | 0.45 UD ĞTest                  │
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Pending                      │ 100.0 ĞTest | 0.05 UD ĞTest                  │
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Locked                       │ 400.0 ĞTest | 0.2 UD ĞTest                   │
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Total balance                │ 1400.0 ĞTest | 0.4848 UD ĞTest               │
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Total (relative to M/N)      │ 0.01 x M/N                                   │
├──────────────────────────────┼──────────────────────────────────────────────┤
│ Total (relative to M)        │ 0.008 % M                                    │
╘══════════════════════════════╧══════════════════════════════════════════════╛

with fields "Available" and "Locked" not displayed if no locked sources.

changed milestone to %0.8.0

assigned to @matograine

Thanks for that! A quick review as it will need you a hard rework and some effort of understanding from your side.

There is already conditions classes implemented into DuniterPy. You might use them. At first, it is hard to understand how things work. I can help you with that. You could also need the transaction document classes.

A question about the design of the architecture of this feature.

Why are you adding a new unlock command?

Why not implementing this in the current tx command? Can you explain your reasons. Sending a transaction is anyway unlocking money sources even with a signature locker SIG().

There is a difference between :

SIG() only "money that only I can spend right now"
SIG() && CSV() (or CLTV) "money that only I can spend after a certain time"
SIG() || SIG(other) && CSV(1_year) "money that I can spend now, or another after a year"

Unlock feature is thought as "send all unlockable sources to myself". The receiver might not want to spend the money to other people. As a receiver, I might want to use the source as early as possible.

However, we may simply add a --unlock option to tx. This would do :

# Spend all usable complex conditions with SIG AND (CSV or CLTV) to myself  
silkaj tx --unlock

# Spend all usable complex conditions with SIG AND (CSV or CLTV or XHX) to myself  
silkaj tx --unlock --passwords 3:14159

# Spend all usable complex conditions with SIG AND (CSV or CLTV or XHX) for a transaction, and use SIG only sources if necessary 
silkaj tx --unlock --passwords 3:14159 --output <receiver> --amount <amount>

# Spend all usable complex conditions with SIG, CSV, CLTV for a transaction, and use SIG only sources if necessary  
# I think all available CSV() and CLTV() sources should be spend as early as possible.  
silkaj tx --output <receiver> --amount <amount>  
silkaj tx --unlock --output <receiver> --amount <amount>

I think this is more elegant and understandable than separate tx and unlock features. Thanks for the comment !

To manage the unlocks in the transaction document, I need a bug in Duniterpy to be resolved. This should be done in Duniterpy 0.56.

Maybe the milestone %0.8.0 is too early. I don't know if and when the release Duniterpy 0.56 is planned

Add ability to unlock and lock transaction with XHX, CSV, CLTV conditions

References

Implementations in Silkaj (should be splitted in multiple tickets)

Child items 0

Activity