Rework transaction functions (Part 4)

Follows #184 (closed)

• tx: sources retrieved twice in get_amount_from_pubkey() and get_sources()
• rename get_amount_from_pubkey() to get_balance()
• handle --allSources with several recipients pubkeys: balance divided among recipients pubkeys
• e745bb95: Refactor the one-liner condition
  • move to transaction_confirmation()?
• Improve variable and function naming:
  • issuers –> issuer: No, there could be many issuers, but it’s not implemented yet
  • issuers should be a list, even if it contains only one element for now.
  • camelize consistency for outputBackChange in code as a variable and as an option. Rename to RecipientBackChange
  • output* —> recipient*:
    • in the code
    • in the cli: pass recipient pubkeys as arguments to be able to specify many without the : split
  • curentUnitBase –> cur*r*entUnitBase
  • amount –> balance
• #193: Dataclass to access units in unit or in cent format
• #119 Simplify confirmation message as now there is a recap chart before sending a transaction
• rework, refactor this whole code

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

changed title from Rework transaction functions (Part 3) to Rework transaction functions (Part 4)

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

changed the description

mentioned in issue #113 (closed)

changed the description

changed milestone to %0.9.0

mentioned in merge request !108 (merged)

I think we should use Duniterpy's Pubkey Type to check the recipients pubkeys before asking for credentials.

There is no PubKey type defined in DuniterPy. This could be a great improvement.

I am agree that checking the pubkey format should be done before the authentication, because in case of authentication failure, we have to restart it.

To check the pubkey format we have crypto_tools.check_public_key().

mentioned in commit 706d0cc5

mentioned in commit 584fb36a

mentioned in merge request !132 (merged)

mentioned in commit d7636e7e

mentioned in commit c7e0069c

marked the checklist item in the cli: pass recipient pubkeys as arguments to be able to specify many without the : split as completed

mentioned in issue #356 (closed)

changed the description

mentioned in merge request !130 (merged)

marked the checklist item tx: sources retrieve twice from get_amount_from_pubkey() and get_sources() as completed

changed the description

Since Silkaj will migrate to GVA, the structure of transactions will change heavily. Reformatting transaction function should be part of this migration. Moving to 0.11 milestone.

changed milestone to %0.11.0

If some cleaning can be done on the code before the migration to GVA, I think this is something to take to avoid having to do both at the same time. Let's see if we manage to squeeze in some changes before the migration to GVA.

changed milestone to %0.10.0

changed the description

marked this issue as related to #184 (closed)

mentioned in commit fc0c8fc1

mentioned in commit e745bb95

changed the description