Get rid of PyNaCl and use base58 module

Use proper libraries: hashlib.sha256 stdlib and base58

• Remove Base58 code, use base58 Python module
  • Add base58 as a direct dependency to Silkaj? It is already a dependency of DuniterPy. Silkaj will still use DuniterPy and DuniterPy will still use base58. Should allow to not have to remove base58 from Silkaj's pyproject.toml when base58 is not longer directly used.
• Remove direct PyNaCl dependency from Poetry and the README.md.
• Instead, use sha256 from hashlib stdlib

mentioned in issue #7 (closed)

changed the description

changed the description

pubkey check seems already here (No, this is an exception with the error message coming from Duniter):

  File "/…/duniterpy/api/client.py", line 142, in requests_get
    raise DuniterError(error_data)
duniterpy.api.errors.DuniterError: Error code 1002 - Pubkey format is incorrect, must be a Base58 string

Missing checksum which must be moved to DuniterPy.

---

There is a pubkey regex check for PubSec authentication file format. We should define this constant for all usages.

changed the description

changed the description

changed milestone to %0.9.0

changed milestone to %0.10.0

added Dep label

mentioned in issue #341 (closed)

changed the description

changed the description

marked this issue as related to #341 (closed)

changed the description

changed milestone to %0.9.0

assigned to @moul

changed the description

marked this issue as related to #294 (closed)

mentioned in issue #294 (closed)

changed title from Move pubkey check and checksum to DuniterPy to Get rid of PyNaCl | Move pubkey check and checksum to DuniterPy

marked the checklist item Remove Base58 code, use base58 Python module as completed

marked this issue as related to duniterpy#131

changed the description

mentioned in commit 1f20724d

mentioned in commit a01ddfd4

mentioned in commit 613594f4

mentioned in commit a791dddb

mentioned in merge request !149 (merged)

marked this issue as related to #352 (closed)

changed title from Get rid of PyNaCl | Move pubkey check and checksum to DuniterPy to Get rid of PyNaCl

changed the description

changed title from Get rid of PyNaCl to Get rid of PyNaCl and use base58 module

closed with merge request !149 (merged)