Migrate from tabulate to texttable
texttable
- texttable
-
Remove
tabulatefrom readme -
Remove no longer necessary
--install-typesoption to installtypes-tabulatesubs module formypypre-commit hook
Better tool? (was easier to develop history), available in most distributions: Debian, Fedora, Arch, FreeBSD…
Differences
-
tabulateuses a list of lists -
texttableuses also a list of lists
To be checked, were there an other difference?
- #220.7.0
Activity
changed milestone to %0.8.0
added ~319 enhancement labels
mentioned in issue #124 (closed)
mentioned in commit 2b18f45d
mentioned in issue #22 (closed)
changed milestone to %0.9.0
mentioned in issue #218
changed milestone to %0.10.0
changed milestone to %0.11.0
added Dep label
Since I would like to begin working on #218 (Add
--full-pubkeyoption), I would like to know if you chose. Tabulate is used in almost every command excepthistory.If we have to choose, maybe we should set a list of criteria. I begin.
tl;dr : both are very similar. Good point for Tabulate is styles. Good point for texttable is max width of tables. I would search a workaround to use a max width with tabulate.
Criteria to be checked
Assign a maximum width for the table
-
texttable. It is used in
history, it is great on small display. - tabulate can't. On small display, tables wrap strangely and are difficult to read. We could find a workaround, but it would be quite annoying.
multiline (#340) : what do we want ?
This (multi-line cells, both do):
+--------+--------+ |a line |a cell | |another | | +--------+--------+or this (to my understanding, none can. To be checked.):
+--------+--------+ |a line | a cell | +--------+ | |another | | +--------+--------+Format
- texttable deals with the type of data (str, int, float, exp, auto)
text float exp int auto ============================================== abcd 67.000 6.540e+02 89 128.001 efghijk 67.543 6.540e-01 90 1.280e+22 lmn 0.000 5.000e-78 89 0.000 opqrstu 0.023 5.000e+78 92 1.280e+22- both can align float on the comma, which is nice to display monetary info. But they don't do it the same way.
tabulate :
>>> print(tabulate([[1.2345],[123.45],[12.345],[12345],[1234.5]])) ---------- 1.2345 123.45 12.345 12345 1234.5 ----------Styles
- texttable has only one style, we can choose to use only/combine headers, columns, lines, borders (see
set_deco) - tabulate has much more available styles.
note : some users include silkaj in scripts, and parse the output. Having custom characters like those used by tabulate styles is not very nice to them.
Availability in UNIX-like distributions
Available in most distribution not a problem:
Lightness
difference is negligible since both are small
- tabulate: 24 kB
- texttable: 10 kB
Speed
according to tabulates propaganda, tabulate is ~2x faster than texttable.
Personal conclusion
I would like to have all the nice styles of tabulate. However, the fact that it can't deal with a fixed with is really a bad point.
I would search a workaround for table width with tabulate, and if I don't find, we should go for texttable.
Edited by matograine-
texttable. It is used in
marked this issue as related to #22 (closed)
marked this issue as related to #218
OR we can use Texttable.set_chars() to get similar table styles as tabulate's "fancy-grid" (not as nice, though) :
Transactions history from: AhRMHUxMPXSeG7qXZrE6qCdjwK9p2bu5Eqei7xAWVEDK:CWj Current balance: 1344300.75 ĞTest, 46.73 UD ĞTest on the 2020-12-10 15:14:13 ┼───────────────┼──────────────┼──────────────┼──────────────┼──────────────┼ │ Date │ Issuers/Reci │ Amounts │ Amounts │ Comment │ │ │ pients │ ĞTest │ UDĞTest │ │ ┼───────────────┼──────────────┼──────────────┼──────────────┼──────────────┼ │ 2020-12-07 │ 6upqFiJ6…:7x │ 300 │ 0.010 │ DEMAIN DES │ │ 19:00:00 │ o │ │ │ L_AUBE │ ┼───────────────┼──────────────┼──────────────┼──────────────┼──────────────┼Transactions history from: AhRMHUxMPXSeG7qXZrE6qCdjwK9p2bu5Eqei7xAWVEDK:CWj Current balance: 1344300.75 ĞTest, 46.73 UD ĞTest on the 2020-12-10 15:16:02 ┼───────────────┼──────────────┼──────────────┼──────────────┼──────────────┼ │ Date │ Issuers/Reci │ Amounts │ Amounts │ Comment │ │ │ pients │ ĞTest │ UDĞTest │ │ ┼═══════════════┼══════════════┼══════════════┼══════════════┼══════════════┼ │ 2020-12-07 │ 6upqFiJ6…:7x │ 300 │ 0.010 │ DEMAIN DES │ │ 19:00:00 │ o │ │ │ L_AUBE │ ┼───────────────┼──────────────┼──────────────┼──────────────┼──────────────┼Edited by matograinemarked this issue as related to #340
Thank you very much for this investigation
Assign a maximum width for the table
That might be the reason why I didn't manage to use
tabulatefor thehistorycommand, and I looked for an alternative. I remember I had a hard time organizing the data structure, and withtexttableI was able to pass a different form of data structure (listoflist,dictoflist, orlistofdict, I do not remember), which made it works.
Regarding #218 (Add
--full-pubkeyoption). If this is a priority for you, please go on. Do it, that shouldn't change that much the code.texttableortabulateand the absence of unit tests shouldn't make a big difference. Create a ticket for this particular feature and link it in #218.OK. I have (partially) found and adapted a wrapper around tabulate, to make it adjust to the screen's size. BUT :
- it is pretty complicated (the original code is to create... a full table. sic. why would we use tabulate ?)
- I encountered lots of glitches (one character too long for a line, one too short for the other, columns too large, etc.) that could not be easily debugged. It is not a good idea to add this complexity to Silkaj.
Meanwhile, I could get pretty nice tables with texttable. I published the code to play with here : $571 .
─────────────────────────────────────────────────────────────────── │ Public key │ amount │ sent │ ─────────────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76LRN:FVm │ 5000.4 │ Yes │ ─────────────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76LRN:FVm │ 0.0 │ No │ ─────────────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76LRN:FVm │ 18.0 │ No │ ─────────────────────────────────────────────────────────────────── with width = 60 (note that the vertical lines are displayed as continuous on my tty emulator) ──────────────────────────────────────────────────────────── │ Public key │ amount │ sent │ ──────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 5000.4 │ Yes │ │ LRN:FVm │ │ │ ──────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 0.0 │ No │ │ LRN:FVm │ │ │ ──────────────────────────────────────────────────────────── │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 18.0 │ No │ │ LRN:FVm │ │ │ ──────────────────────────────────────────────────────────── │──────────────────────────────────────────│────────│──────│ │ Public key │ amount │ sent │ │══════════════════════════════════════════│════════│══════│ │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 5000.4 │ Yes │ │ LRN:FVm │ │ │ │──────────────────────────────────────────│────────│──────│ │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 0.0 │ No │ │ LRN:FVm │ │ │ │──────────────────────────────────────────│────────│──────│ │ d88fPFbDdJXJANHH7hedFMaRyGcnVZj9c5cDaE76 │ 18.0 │ No │ │ LRN:FVm │ │ │ │──────────────────────────────────────────│────────│──────│I would definitely go for texttable.
Edited by matograine-
You can paste some code in the snippet feature (on the left side with
Edited by Moul changed milestone to %0.10.0
assigned to @matograine
-
@matograine, please update the title, the targeted milestone, and the assignee to reflect the current status. I did it for this ticket.
Edited by Moul mentioned in commit c46c64fd
mentioned in commit 2b9f4380
mentioned in commit ccb655e7
mentioned in commit aa33280f
mentioned in commit 765a8982
mentioned in commit 698219a7
mentioned in commit 2d99d16f
mentioned in commit 74dc1489
mentioned in commit 740b2aa0
mentioned in commit fdcc418d
mentioned in commit f3a56fd1
mentioned in commit a745056b
mentioned in commit 370a842e
mentioned in commit f4b63b78
mentioned in commit ac4ba575
mentioned in commit 24b05f59
mentioned in commit 97599acb
mentioned in commit 1565acfa
mentioned in commit e074b988
mentioned in commit 00e4979c
mentioned in commit 467002a4
mentioned in commit 64fbe601
