Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
silkaj
silkaj
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 155
    • Issues 155
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 5
    • Merge Requests 5
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • clients
  • python
  • silkajsilkaj
  • Issues
  • #344

Closed
Open
Opened Oct 04, 2020 by Moul@moulOwner0 of 3 tasks completed0/3 tasks

Fix import loop issue

The following discussion from !143 (merged) should be addressed:

  • @moul started a discussion: (+1 comment)

    Is there anything that can be done for this import loop issue? Did you try to understand the importation process order? I haven't check in details, but this is usually due to a wrong architectural design.


  • Use pendulum everywhere, and get rid of convert_time()
  • Remove following weird imports:
grep -rnA1 "had to import" silkaj
silkaj/money.py:27:# had to import from wot to avoid loop dependencies
silkaj/money.py-28-from silkaj.wot import check_public_key
--
silkaj/auth.py:26:# had to import pubkey_with_checksum from wot to avoid loop dependency.
silkaj/auth.py-27-from silkaj.wot import pubkey_with_checksum
--
silkaj/wot.py-29-from silkaj.tui import convert_time, pubkey_with_checksum
Edited Oct 04, 2020 by Moul
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
0.9.0
Milestone
0.9.0
Assign milestone
Time tracking
None
Due date
None
Reference: clients/python/silkaj#344