Merge DeathReaper '256_excluded' branch on 'main' branch
Image
-
image/pipswitch tobookwormor remove Debian version specification to get latest, risky? -
Adapt image/{pip,poetry}to install extrapydiscourse:pip install . silkaj[deathreaper]poetry install --extras "deathreaper"
Packaging extra solution
-
Use Poetry extraor dependency grouping (from Poetry v1.2) to separatepydiscoursenot available in Debian.
pydiscourse = { version = "^1.3.0", optional = true }
[tool.poetry.extras]
deathreaper = ["pydiscourse"]
-
When pydiscourseis not importable, do not addexcludedcommand to the list:
# cli.py
import contextlib
with contextlib.suppress(ModuleNotFoundError):
from silkaj.blockchain.wot import excluded_command
wot_group.add_command(excluded_command)
Implementation sources
-
Rebase 256_excludedbranch onmainbranch-
fix hooks, pytest new reports
-
-
Move blockchain excludedcommandwot exclusionsCLI command group and directories.- It’s a
blockchainevent, but it’s morewotrelated and better placed there. Since the command will be publicly available now via PyPI installation. Wasn’t planned in #330 (closed) nor in #430 (closed), but rebased and not thought through. -
blockchain excludedwas taken from BMA pathblockchain/excluded.
- It’s a
-
Say in help command that’s it’s DeathReaper
Documentation
-
Document how to install Deathreaper: pipx install silkaj[deathreaper]. Dedicateddoc/deathreaper.mdfile: install, usage -
Add a line in readme about this feature
Operation
DeathReaper repo
-
Use image from mainchannel/branch -
Use wot exclusions - Have to use
poetryimage since we needgitto clone DuniterPy used from repomainbranch- Switch back to
pipimage usage once DuniterPy is used from PyPI release: Switch DuniterPy usage back to PyPI release (#483 - closed)
- Switch back to
Silkaj repo
-
Create MR to mainbranch: delete256_excludedbranch -
Create image on mainchannel/branch -
Test things still works fine
After
-
Delete 256_excludedimages
Benefit: no need to maintain an other branch with new features coming from main branch when rebasing, such as pre-commit hooks checks.
Priority to be considered regarding Substrate migration. With Substrate, a better system could be setup. An web based email registration system, which would be listening to the blockchain/RPC or the Indexer and then send email. This would be a more efficient system, since now G1 members do not have forums accounts.
Edited by Moul