Skip to content
Snippets Groups Projects

WIP : #111 Send multiple outputs

Closed matograine requested to merge matograine/silkaj:multiple_outputs into dev

Adding the function to send multiple outputs. This MR uses the !104 (closed) changed confirmation display, I don't know if this is the right way to submit MRs.

Adding total_amount() function.

Variables amounts and OutputAddresses should now be lists. However, I kept the case where it is a string. This might be removed if not necessary, but I didn't want to break anything (I broke the intermediary_tx function during development).

I took care of intermediary transactions, and tested it on GTest.

I tried to write tests, however, I could not run them due to #241 (closed) (Click). I did not use Poetry for now, it seems to be the workaround.

!! CAUTION !! I had to deal with the base issue on testing (Gtest). There are two round (amount, -2) in function transaction_amount() that should be removed before merging.

Edited by matograine

Merge request reports

Checking pipeline status.

Approval is optional

Closed by MoulMoul 5 years ago (Nov 24, 2019 12:47pm UTC)

Merge details

  • The changes were not merged into dev.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading