Skip to content
Snippets Groups Projects

WIP: Output backchange #165

Closed matograine requested to merge (removed):output_backchange into dev
1 unresolved thread

Worked on issue 165 : outputBackChange.

Not sure if my merge request is correctly done. There are merge conflicts and I don't know how to correct it.

btw, I wrote this feature, but I don't understand why "backchange" != (previous_amount - tx_amount). So, maybe I missed a point. Like the amount of backchange.

Edited by matograine

Merge request reports

Checking pipeline status.

Closed by MoulMoul 5 years ago (Mar 18, 2019 10:31pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
150 150 id_to = get_uid_from_pubkey(outputAddress)
151 151 if id_to is not NO_MATCHING_ID:
152 152 tx.append(["to (id)", id_to])
153 tx.append(["Backchange (pubkey)", outputBackChange])
154 id_backchange = get_uid_from_pubkey(outputBackChange)
155 if id_backchange is not NO_MATCHING_ID:
156 tx.append(["Backchange (id)", id_backchange])
  • Looks great!

    You should cover the case when outputBackChange is not define by encapsulating this block of code with:

    if outputBackChange:

    I can take care to resolve the conflict. This looks a bit advance in git knowledge.


    I don't understand why "backchange" != (previous_amount - tx_amount). So, maybe I missed a point. Like the amount of backchange.

    Backchange amount should be pubkey’s balance minus tx amount.

    Did you notice an error, a different value? I am not sure to get your question.

    The idea is to send back the rest from a pubkey to an other pubkey as the credentials for this first key are now known. This was built for the PaperWallet usage.

    Edited by Moul
  • Please register or sign in to reply
  • Moul assigned to @moul

    assigned to @moul

  • Moul changed milestone to %0.7.0

    changed milestone to %0.7.0

  • Done in 30d83142.

    Edited by Moul
  • closed

  • added D: Transfer label

  • Please register or sign in to reply
    Loading