#236 Confirmation display - good MR
- Modify the confirmation display.
- Add tests for transaction confirmation.
Merge request reports
Activity
added D: Transfer Test enhancement labels
mentioned in merge request !104 (closed)
changed milestone to %0.8.0
assigned to @moul
added 7 commits
-
25fd970f - 1 commit from branch
dev - bcb02d7a - modify confirmation display. Add functions display_output(), display_amount(),...
- 2b0df4ec - Writing tests for tx functions. Apply black on tx.py
- 75f757a2 - removing display_output_and_amount
- 43d56634 - remove display_output_and_amount() from tests, add transaction_confirmation()...
- 339f4e2c - adding tx parameter in display_pubkey() for Backchange.
- 9e10a4e8 - * make display_amount() lighter and add currency_symbol after "UD"
Toggle commit list-
25fd970f - 1 commit from branch
added 7 commits
- 68203baa - modify confirmation display. Add functions display_output(), display_amount(),...
- b928e0c8 - Writing tests for tx functions. Apply black on tx.py
- c7f9f639 - removing display_output_and_amount
- 44ecd966 - remove display_output_and_amount() from tests, add transaction_confirmation()...
- b8a55173 - adding tx parameter in display_pubkey() for Backchange.
- 0ec4270b - LEARNING GIT BAYBY (nothing changed, still conflicts to resolve)
- 18569ebc - can't manage to mock functions
Toggle commit listmentioned in merge request !105 (closed)
changed title from WIP : #236 (closed) Confirmation display to WIP : #236 (closed) Confirmation display - good MR
added 15 commits
-
18569ebc...715516aa - 3 commits from branch
dev - 0f557c54 - modify confirmation display. Add functions display_output(), display_amount(),...
- b131671b - Writing tests for tx functions. Apply black on tx.py
- 83c0a309 - removing display_output_and_amount
- 6c4404f0 - remove display_output_and_amount() from tests, add transaction_confirmation()...
- 554f4362 - adding tx parameter in display_pubkey() for Backchange.
- fd21271a - modify confirmation display. Add functions display_output(), display_amount(),...
- 9b863222 - Writing tests for tx functions. Apply black on tx.py
- d186a9d8 - removing display_output_and_amount
- 05ff453c - remove display_output_and_amount() from tests, add transaction_confirmation()...
- de5c657a - * make display_amount() lighter and add currency_symbol after "UD"
- 7f838c7d - can't manage to mock functions
- c3262cd8 - working tests for tx confirmation with monkeypatch functions
Toggle commit list-
18569ebc...715516aa - 3 commits from branch
added Interface label
-
Ok, I think we are almost ready to merge it! You’ll have to rebase it on
devbranch. There is an issue withpytest-3.8job which wasn’t passing.Can you make a clean history out of that? With commit messages explaining what are the changes. With the ticket linked (#236 (closed)).
You can backup your work creating a new branch before changing the history:
checkout -b copy_confirmation_display.Edited by Moul added 7 commits
-
73ea3edc...f335a2bd - 5 commits from branch
dev - 820ad606 - issue #236 (closed)
- f99b39d4 - issue #236 (closed) : adding tests
-
73ea3edc...f335a2bd - 5 commits from branch
added 2 commits
- ad5e8b06 - issue #236 (closed) : modify confirmation display
- 888b794b - adding tests for issue #236 (closed).
changed title from WIP : #236 (closed) Confirmation display - good MR to #236 (closed) Confirmation display - good MR
161 tx.append( 162 [ 163 "tx amount (unit)", 164 str(tx_amount / 100 * len(outputAddresses)) + " " + currency_symbol, 165 ] 166 ) 167 tx.append( 168 [ 169 "tx amount (relative)", 170 str(round(tx_amount / await UDValue().ud_value, 4)) 171 + " UD " 172 + currency_symbol, 173 ] 190 191 await display_amount( 192 tx, "total amount", float(tx_amount * len(outputAddresses)), currency_symbol added 2 commits
- ceb7c1a3 - [enh] #236 (closed): improve the tx confirmation display
- 5b990cb5 - [test] #236 (closed): add tests for tx confirmation, mock functions:
