Skip to content
Snippets Groups Projects

#301: Generalize pubkey checksum display and check

Merged #301: Generalize pubkey checksum display and check
Merged matograine requested to merge display_checksum into dev

pubkey:checksum format is displayed and can be passed to all commands. The checksum is validated.

Splits check_public_key() function into three functions:

  • is_pubkey_and_check()
  • check_pubkey_formet()
  • validate_checksum()
  • gen_checksum()

Create display_pubkey_with_checksum() function

Creates and update related tests.

Close #301 (closed), #320 (closed).

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul
  • Moul
  • matograine added 8 commits

    added 8 commits

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • Moul
  • Moul
  • Moul
  • matograine added 9 commits

    added 9 commits

    Compare with previous version

  • matograine added 9 commits

    added 9 commits

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • @moul, just to be sure, can I merge ?

  • Moul
  • Things looks good for now. I wanted to do further checks.

    The MR will be approved with the approval feature when ok from my side.

  • matograine added 10 commits

    added 10 commits

    Compare with previous version

  • matograine changed the description

    changed the description

  • Moul resolved all threads

    resolved all threads

  • Moul
  • matograine added 10 commits

    added 10 commits

    Compare with previous version

  • Moul changed title from #301 (closed): Generalize pubkey’s checksum display to #301 (closed): Generalize pubkey checksum display

    changed title from #301 (closed): Generalize pubkey’s checksum display to #301 (closed): Generalize pubkey checksum display

  • Moul resolved all threads

    resolved all threads

  • Moul changed the description

    changed the description

  • Moul changed title from #301 (closed): Generalize pubkey checksum display to #301 (closed): Generalize pubkey checksum display and check

    changed title from #301 (closed): Generalize pubkey checksum display to #301 (closed): Generalize pubkey checksum display and check

  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul mentioned in issue #344 (closed)

    mentioned in issue #344 (closed)

  • Moul
  • Moul
  • matograine added 14 commits

    added 14 commits

    Compare with previous version

  • Moul
  • Moul
  • Interesting thing : If you use wot with a part of someone's uid, silkaj answers.

    $ silkaj wot atogr
    Matograine (CmFKubyq…:CQ5) from block #106433-00000340…
    received 11 and sent 25/100 certifications:
    ...

    I think it is a cool feature. There is no problem leaving it as it is, since a choice will be asked if there are many answers.

    $ silkaj wot ato
    |   id | uid             | pubkey                                           | timestamp             |
    |------+-----------------+--------------------------------------------------+-----------------------|
    |   00 | 13megatonnes    | hmQxjHC9Vn173CX4UaSpqiqjDXY5iqD41yeJcUsgGBZ:63c  | 362032-00000016C2547… |
    |   10 | alouatouf77     | sieUwCWvHKzDLf2hBc3u8shTFPJ9uGpgJKFNLSmdwit:D7m  | 362177-0000001006228… |
    |   20 | Duraton         | 9ad856NFt5kNqUkUzAXeBhGVAoJoZ1ATWqQvgjCzJRUP:9jo | 332446-0000005396EEA… |
    |   30 | Fiatoux         | 5WD4WSHE96ySreSwQFXPqaKaKcwboRNApiPHjPWB6V9C:EnZ | 0-E3B0C44298FC1C149A… |
    ...

    It also works with parts of pubkeys :

    $ silkaj wot FhgFDYqwcKgG
    enoratatouille (FhgFDYqw…:2W2) from block #205549-0000042A…
    received 5 and sent 2/100 certifications:
    ...
    Edited by matograine
  • Moul
  • Moul
  • matograine added 13 commits

    added 13 commits

    Compare with previous version

  • Moul
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading