Skip to content
Snippets Groups Projects

#172, #314, #328, #378: Implement display option for membership and cert commands

Merged #172, #314, #328, #378: Implement display option for membership and cert commands
All threads resolved!
Merged Moul requested to merge 314_display_option into dev
All threads resolved!
  • tx: monkeypatch.setattr(module, method)
  • #172 (closed): Rename transaction_confirmation to gen_confirmation_table
  • #172 (closed): Refactor tx confirmation, by using click.confirm()
  • cert: Split pre-checks and docs gen into f()
  • #314: cert: Implement display option
    • The generated document is displayed
    • In case the option is passed, display the table and
    • the generated document
  • #314: membership: Implement display option
    • Add ability to send the doc after displaying the doc
    • Do not by-pass the license approval
    • Issuance approval after confirmation and doc display
    • Set one confirmation prompt after the table and the document displays
    • Use dry-run global option
    • Add test for the display option
  • #314: Add global --display/-d and --dry-run/-n options
    • display option to display the generated document before sending it
    • Move dry-run option as a general one
    • Add error handling to have dry-run and display options together
    • Test when display and dry_run options are passed together
  • #378: Create and use generic send_doc_confirmation() in cert and membership commands
  • #328: cert/tx: Import top-level Click module
  • #328: Import directly tui module for cert, membership, tui (constants)
Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • matograine
  • matograine
  • matograine
  • matograine
  • Moul added 18 commits

    added 18 commits

    Compare with previous version

  • Moul added 18 commits

    added 18 commits

    Compare with previous version

  • Moul added 5 commits

    added 5 commits

    Compare with previous version

  • matograine
  • Moul added 12 commits

    added 12 commits

    Compare with previous version

  • Moul added 7 commits

    added 7 commits

    Compare with previous version

  • Moul changed title from Implement display option for membership and cert commands to #165: Implement display option for membership and cert commands

    changed title from Implement display option for membership and cert commands to #165: Implement display option for membership and cert commands

  • Moul changed title from #165: Implement display option for membership and cert commands to #314: Implement display option for membership and cert commands

    changed title from #165: Implement display option for membership and cert commands to #314: Implement display option for membership and cert commands

  • Moul added 8 commits

    added 8 commits

    Compare with previous version

  • matograine resolved all threads

    resolved all threads

  • matograine
  • Moul added 9 commits

    added 9 commits

    Compare with previous version

  • Moul added 13 commits

    added 13 commits

    Compare with previous version

  • matograine
  • Moul changed title from #314: Implement display option for membership and cert commands to #172, #314, #328, #378: Implement display option for membership and cert commands

    changed title from #314: Implement display option for membership and cert commands to #172, #314, #328, #378: Implement display option for membership and cert commands

  • Moul changed the description

    changed the description

  • Moul added 10 commits

    added 10 commits

    Compare with previous version

  • matograine
  • matograine
  • matograine approved this merge request

    approved this merge request

  • Moul added 2 commits

    added 2 commits

    • d7be34f0 - No commit message
    • 01717c03 - [mod] tx: monkeypatch.setattr(module, method)

    Compare with previous version

  • Moul added 2 commits

    added 2 commits

    • 4fdefbea - [mod] #172 (closed): Rename transaction_confirmation to gen_confirmation_table
    • 01c942f9 - [mod] tx: monkeypatch.setattr(module, method)

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • Moul enabled an automatic merge when the pipeline for 01c942f9 succeeds

    enabled an automatic merge when the pipeline for 01c942f9 succeeds

  • merged

  • Please register or sign in to reply
    Loading