CI : remove GET params at the end of assets URLs

fix #38

I assign @moul. I have no knowledge in Gitlab CI, please review carefully.

requested review from @moul

assigned to @HugoTrentesaux

I consider this change not ready for review, since I think it’s breaking the upload feature. You should be sure it fixes the issue before asking for review (specially in this case)! Otherwise, it’s the reviewer’s job to actually fix the issue by reading CI’s syntax reference doc or testing. You can test how the CI behave by creating a simple repository, trying to upload and download a file with your change. That’s a good exercise to begin with GitLab CI/CD. If not, then we let it as is. I consider renaming a file after using wget Okayish. Btw, there is no such issue when clicking on the link!

Ok, you might be right. I don’t see any mention of ?job= in https://docs.gitlab.com/ee/ci/yaml/#releaseassetslinks nor in https://docs.gitlab.com/ee/user/project/releases/release_fields.html#release-assets. This could fix the issue. @pokapow, any reason for having ?job=$job_name in the URL? Would the upload/link creation on the release page still work?

unassigned @HugoTrentesaux

I'm bad at CI too. I do not want to write or maintain it.

Waiting for @pokapow’s answer. Otherwise, I am planning to test this on the main branch with a 0.3.1 tag that I might delete if it doesn’t work. Is this fine, do I get your approval?

I don't remember why Claude3 made this CI like this, you can change what you it would probably be better.

approved this merge request

mentioned in commit 9460516b

merged

mentioned in commit 4e90dae3

I simply reverted the change since it does not solve the issue. We can’t download the targets because they are missing ?job=$job_name suffix. I deleted the tag 0.3.1, therefore the release can’t be seen anymore, so users don’t complain. But, trust me the links are therefore broken unless you add the suffix ;)

Actually, there is an email for the release

Assets:

• gcli v0.3.1 Debian Package: https://git.duniter.org/clients/rust/gcli-v2s/-/jobs/artifacts/0.3.1/raw/target/debian/gcli_0.3.0-1_amd64.deb
• gcli v0.3.1 for macOS: https://git.duniter.org/clients/rust/gcli-v2s/-/jobs/artifacts/0.3.1/raw/target/macos/gcli.zip
• gcli v0.3.1 for Linux (binary): https://git.duniter.org/clients/rust/gcli-v2s/-/jobs/artifacts/0.3.1/raw/target/release/gcli

mentioned in issue #38