Skip to content
Snippets Groups Projects

feat: Can choose between ed25519 ans sr25519

Merged poka requested to merge choose-ed25519 into master
All threads resolved!

Cette MR permet de:

  • Choisir explicitement si nous voulons importer un wallet en mode ed25519 (par defaut) ou sr25519.
gcli vault import -c sr25519
gcli vault import --crypto-scheme sr25519
  • Par defaut ne jamais afficher les pubkey (format key g1v1), mais quelque soit le type, pouvoir afficher les keys g1v1:
gcli vault list all --show-g1v1
  • Permet de dériver des clés de type ed25519, car il n'y a pas de raison de l'empêcher

Merge request reports

Pipeline #40318 passed

Pipeline passed for c0da476b on choose-ed25519

Approved by

Merged by Nicolas80Nicolas80 3 months ago (Apr 8, 2025 6:41pm UTC)

Merge details

  • Changes merged into master with bb54cc00 (commits were squashed).
  • Deleted the source branch.

Pipeline #40319 passed

Pipeline passed for bb54cc00 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas80
  • Nicolas80
  • Nicolas80
    • Resolved by Nicolas80

      Nice change in general; but I found some potential issues and had a few remarks :smiley:

      It's a bit sad that we won't be able to differentiate between a g1v1 key and any other in the ed25519 scheme; but I guess we can live with that (it would probably not be a great idea to add yet another column just for that).

      And a general note that @HugoTrentesaux gave me on my merge requests before; if possible use both

      # Format the code so that next person that does it won't have a bunch of unrelated changes in the MR
      cargo fmt
      
      # Check for all issues that can be resolved
      cargo clippy

      Regarding clippy; I have a local change of config.toml file which I do not commit:

      [build]
      # For ignoring manually deprecated functions linked to key files - do NOT commit ! "-A deprecated"
      rustflags = [
          "-A", "deprecated"
      ]

      (I did deprecate several things linked to the old key files and we should keep them for some time until people have had the opportunity to migrate them to the sqlite db)

      And in this case; with that config; it finds several unused functions

      For info; I never touched those 2 that remains as I didn't change those parts:

      warning: unexpected `cfg` condition value: `dev`
       --> src/commands/transfer.rs:3:11
        |
      3 | #[cfg(any(feature = "dev", feature = "gdev"))] // find how to get runtime calls
      
      warning: the borrowed expression implements the required traits
        --> src/commands/net_test.rs:35:48
         |
      35 |             .fetch(&runtime::storage().system().account(&pair_i.public().into()))
  • poka added 1 commit

    added 1 commit

    Compare with previous version

  • poka added 2 commits

    added 2 commits

    • e9cd6a99 - Add secret format in database and display
    • a36c8318 - remove unused methods

    Compare with previous version

  • poka added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas80
  • Nicolas80
  • Nicolas80
  • Nicolas80
  • Nicolas80
  • Nicolas80 mentioned in issue #47

    mentioned in issue #47

  • Nicolas80 added 5 commits

    added 5 commits

    • cfda5c16 - * Small fix in doc of function
    • 3738e8b7 - * Fix for `vault migrate` that should use sr25519 scheme to be consistent
    • 44073020 - * Adding `-c` crypto scheme parameter (with default ed25519) in different places
    • da7c790d - * Added some logic between arguments of `vault import`; can't provide both...
    • 8bf81cbc - * Adapted catch_known of predefined derivations to properly handle both...

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 0da71079 - * reverted most of the commit e9cd6a99: "Add secret format in database and display"

    Compare with previous version

  • Nicolas80 resolved all threads

    resolved all threads

  • Nicolas80 added 1 commit

    added 1 commit

    • bbd95707 - Added extra message when the DB parsing of DbAccountId fails, so we know for...

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    Compare with previous version

  • @HugoTrentesaux, @pokapow could you review the changes ?

    I also bumped the version to 0.4.1 and added a CHANGELOG.md entry so we could do a release of this change.

    Edited by Nicolas80
  • Nicolas80 resolved all threads

    resolved all threads

  • Hugo Trentesaux
  • Hugo Trentesaux approved this merge request

    approved this merge request

  • Nicolas80 added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas80 added 4 commits

    added 4 commits

    • 72462b98 - Code review:
    • 13307c1a - * Changed sorting of children account so that they are sorted by Path value...
    • 31767968 - * Small clippy cleanup
    • 49e609c7 - Code review:

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 4a82b65d - * Small change to show the linked `<Base>` account if different from the one we inspect.

    Compare with previous version

  • Hugo Trentesaux requested changes

    requested changes

  • Hugo Trentesaux mentioned in issue #52

    mentioned in issue #52

  • Nicolas80 added 1 commit

    added 1 commit

    • 756418ac - * Small refactoring to move method to vault.rs

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 1071f330 - * Renamed AccountLinkParams to SecretProvider and adapted descriptions to...

    Compare with previous version

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Nicolas80 added 1 commit

    added 1 commit

    • d664f4a2 - * Refactored method get_keypair_from_secret_provider into SecretProvider...

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 3e96d537 - * Small change to be in line with the adapted parameter descriptions

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 8d6df397 - * Added extra data in `vault inspect` command

    Compare with previous version

  • Nicolas80 added 1 commit

    added 1 commit

    • 4b410eeb - * Updated CHANGELOG.md with `vault inspect` changes

    Compare with previous version

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Nicolas80 added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • poka mentioned in commit bb54cc00

    mentioned in commit bb54cc00

  • Please register or sign in to reply
    Loading