feat: Can choose between ed25519 ans sr25519
Cette MR permet de:
- Choisir explicitement si nous voulons importer un wallet en mode ed25519 (par defaut) ou sr25519.
gcli vault import -c sr25519
gcli vault import --crypto-scheme sr25519
- Par defaut ne jamais afficher les pubkey (format key g1v1), mais quelque soit le type, pouvoir afficher les keys g1v1:
gcli vault list all --show-g1v1
- Permet de dériver des clés de type ed25519, car il n'y a pas de raison de l'empêcher
Merge request reports
Activity
requested review from @Nicolas80
assigned to @pokapow
@Nicolas80 je te laisse relire cette MR ?
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
Nice change in general; but I found some potential issues and had a few remarks
It's a bit sad that we won't be able to differentiate between a g1v1 key and any other in the ed25519 scheme; but I guess we can live with that (it would probably not be a great idea to add yet another column just for that).
And a general note that @HugoTrentesaux gave me on my merge requests before; if possible use both
# Format the code so that next person that does it won't have a bunch of unrelated changes in the MR cargo fmt # Check for all issues that can be resolved cargo clippy
Regarding clippy; I have a local change of
config.toml
file which I do not commit:[build] # For ignoring manually deprecated functions linked to key files - do NOT commit ! "-A deprecated" rustflags = [ "-A", "deprecated" ]
(I did deprecate several things linked to the old key files and we should keep them for some time until people have had the opportunity to migrate them to the sqlite db)
And in this case; with that config; it finds several unused functions
For info; I never touched those 2 that remains as I didn't change those parts:
warning: unexpected `cfg` condition value: `dev` --> src/commands/transfer.rs:3:11 | 3 | #[cfg(any(feature = "dev", feature = "gdev"))] // find how to get runtime calls warning: the borrowed expression implements the required traits --> src/commands/net_test.rs:35:48 | 35 | .fetch(&runtime::storage().system().account(&pair_i.public().into()))
added 2 commits
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
- Resolved by Nicolas80
mentioned in issue #47
added 5 commits
- cfda5c16 - * Small fix in doc of function
- 3738e8b7 - * Fix for `vault migrate` that should use sr25519 scheme to be consistent
- 44073020 - * Adding `-c` crypto scheme parameter (with default ed25519) in different places
- da7c790d - * Added some logic between arguments of `vault import`; can't provide both...
- 8bf81cbc - * Adapted catch_known of predefined derivations to properly handle both...
Toggle commit listadded 1 commit