add smith and membership commands
1 unresolved thread
1 unresolved thread
addresses #1 (closed) #3 (closed)
and add other things
Edited by Hugo Trentesaux
Merge request reports
Activity
Filter activity
assigned to @HugoTrentesaux
requested review from @tuxmain
I added you as a reviewer event if this is draft because it is adding a lot of features (git commit names):
- add also smith member count to reveal bug
- add member count
- refac calls
- refac claim membership
- refac membership renewal
- add smith membership renewal
- add smith membership claim
- add manual sealing
- submit tx without waiting for result
- add test account derivations
- add certify command
If there is no bug inside it could be good to merge as is.
176 180 } 177 181 self 178 182 } 179 183 /// build from config 180 184 pub fn build_from_config(mut self) -> Self { 181 // if a secret is defined, build keypair 185 // if a secret is defined, build keypair and silently overwrite address 182 186 if let Some(secret) = self.cfg.secret.clone() { 183 187 let (address, keypair) = 184 188 addr_and_pair_from_secret(SecretFormat::Predefined, &secret).unwrap(); 185 // if an address is already defined and differs from secret, warns user 186 if let Some(address_) = self.cfg.address { 187 if address_ != address { 188 println!("overwriting address ({address_}) from secret ({address})"); 189 } 190 } removed review request for @tuxmain
Please register or sign in to reply