Skip to content
Snippets Groups Projects

add smith and membership commands

Merged Hugo Trentesaux requested to merge hugo-dev into master
1 unresolved thread

addresses #1 (closed) #3 (closed)

and add other things

Edited by Hugo Trentesaux

Merge request reports

Checking pipeline status.

Merged by Hugo TrentesauxHugo Trentesaux 1 year ago (Oct 23, 2023 2:08pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
176 180 }
177 181 self
178 182 }
179 183 /// build from config
180 184 pub fn build_from_config(mut self) -> Self {
181 // if a secret is defined, build keypair
185 // if a secret is defined, build keypair and silently overwrite address
182 186 if let Some(secret) = self.cfg.secret.clone() {
183 187 let (address, keypair) =
184 188 addr_and_pair_from_secret(SecretFormat::Predefined, &secret).unwrap();
185 // if an address is already defined and differs from secret, warns user
186 if let Some(address_) = self.cfg.address {
187 if address_ != address {
188 println!("overwriting address ({address_}) from secret ({address})");
189 }
190 }
  • Comment on lines -185 to -190

    Pourquoi ? Je préfère limiter les comportements "intelligents" et les rendre transparents et prédictibles. Là on ne sait pas forcément quelle est la clé utilisée, surtout si la commande utilise seulement la clé publique.

  • Effectivement, il faudrait choisir les règles de priorité entre le fichier de config et les arguments en ligne de commande. Il faudrait voir les cas d'usage pour lesquels on veut avoir address défini mais non cohérent avec let sercret défini.

  • Please register or sign in to reply
  • Hugo Trentesaux marked this merge request as ready

    marked this merge request as ready

  • Hugo Trentesaux changed title from Draft: Draft to add smith and membership commands

    changed title from Draft: Draft to add smith and membership commands

  • Hugo Trentesaux changed the description

    changed the description

  • Je merge en l'état, je préfère avancer vite sur Ğcli quitte à modifier des choses après. J'ai besoin d'avoir une branche synchro avec Duniter.

  • Hugo Trentesaux removed review request for @tuxmain

    removed review request for @tuxmain

  • Please register or sign in to reply
    Loading