inc_sufficients for old_owner_key

In the identity pallet we have contradictory instructions:

• In GenesisBuild we increment sufficients for old_owner_key
• In change_owner_key we decrement it

changed milestone to %runtime-801

added C-binary C-runtime P5-sometimesoon RN-runtime labels

I will take this one with #198 (closed) that I want to investigate and that is be related to the sufficients/providers accounting and old_owner_key.

assigned to @bgallois

mentioned in merge request !241 (merged)

I believe there is no error in this scenario because at genesis, we have the following configuration:

• owner_key: 0 + 1
• old_owner_key: 0 + 1

During the key change process:

• owner_key: 0 + 1
• old_owner_key: 1 + 0
• old_old_owner_key: 1 - 1

So in the end, the new 'owner_key' will be set to 1. The 'old_key', which already has a sufficient count of 1 from the previous key change, will remain at 1. Meanwhile, the 'old_old_key' will have a value of 0 and can be reaped.

After thinking about it, I do not see why we should force old_owner_key account to keep existing. It can be reaped without consequences.

closed with merge request !241 (merged)

added genesis label