Check if UD is using well pallet balances

See https://forum.duniter.org/t/add-balances-to-squid-accounts/12782/4

check why UniversalDividend.UdsClaimed does not come with Balances.Issued but Balances.Deposit.

I thought universal dividend should emit balances.issued event in order to update the total issuance. It seems to be emitting balance.deposit instead. Are we using the API well? Is the total issuance ok?

Test test_total_issuance_vs_monetary_mass() tests that, but we should double check that the total issuance is coherent with the emitted events.

added C-integrationtests label

assigned to @HugoTrentesaux

We have the choice depending on the events:

Current implementation

let _ = T::Currency::deposit(who, uds_total, Precision::Exact);

// these events
// RuntimeEvent::Balances(Event::Deposit { who: 1, amount: 1000 }), topics: [] }, 
// RuntimeEvent::UniversalDividend(Event::UdsClaimed { count: 1, total: 1000, who: 1 }), topics: [] }

Suggestion with issue

// Currency is issued here
let credit = T::Currency::issue(uds_total);
// The credit is resolved into the claimer's account
// We ignore the case where UD can not be claimed
let _ignore_error = T::Currency::resolve(who, credit);
Self::deposit_event(Event::UdsClaimed {
    count: uds_count,
    total: uds_total,
    who: who.clone(),
});

// these events
// RuntimeEvent::Balances(Event::Issued { amount: 1000 }), topics: [] }, 
// RuntimeEvent::Balances(Event::Deposit { who: 1, amount: 1000 }), topics: [] }, 
// RuntimeEvent::UniversalDividend(Event::UdsClaimed { count: 1, total: 1000, who: 1 }), topics: [] }

Suggestion with mint

let _ = T::Currency::mint_into(who, uds_total)?;

// these events
// RuntimeEvent::Balances(Event::Minted { who: 1, amount: 1000 }), topics: [] }, 
// RuntimeEvent::UniversalDividend(Event::UdsClaimed { count: 1, total: 1000, who: 1 }), topics: [] }

I think that "mint" is more appropriate for Universal Dividend.

added S-needdiscussion label

created branch 279-check-if-ud-is-using-well-pallet-balances to address this issue

mentioned in merge request !307 (merged)

closed with merge request !307 (merged)