Auto-claim UDs when membership renew

If a wallet renew membership (via distance evaluation) but never claim UDs, the user can lost some UDs.

To make sure that UDs lost is impossible, the runtime should automatically claim UDs in OnValidDistanceStatus implementation.

https://forum.duniter.org/t/incorrect-universaldividend-computation-in-gcli/12915/5

added C-runtime D-easy ET-days I-ToPrioritize labels

As a reminder, someone loosing its membership will auto-claim UDs:

https://git.duniter.org/nodes/rust/duniter-v2s/blob/master/pallets/universal-dividend/src/lib.rs#L469-473

That said, IMHO it's OK to loose unproduced UDs 80 years ago with a continuous membership on that same period of time.

it's OK to loose unproduced UDs 80 years ago with a continuous membership on that same period of time.

Ok, I’ll close it for now, but it could make sense as an additional security measure if one day the community decide to reduce the UD re-evaluation interval for some reason

closed

I’m reopening the issue with low priority for two reasons:

1. If our successors decide to reduce the re-evaluation interval of the UD without increasing MaxPastReeval, it will introduce a bug. I believe it’s beneficial to aim for a code design that is resistant to potential future errors whenever possible.
2. This would allow us to lower the value of MaxPastReeval, which would reduce the computational load on wallets/explorers wanting to compute transferable balances without relying on an indexer (like a full p2p wallet using smoldot light client for example).

reopened

removed I-ToPrioritize label

added P9-somedaymaybe label