Bug: a smith member can change_owner_key before go_online

The bug reported at Issue #245 (closed) is not fully fixed by Merge Request !277 (merged).

The association IdtyIndex -> AccountId is created when a smith member sets their session keys: https://git.duniter.org/nodes/rust/duniter-v2s/-/blob/master/pallets/authority-members/src/lib.rs#L333.

Then, the smith member can change their AccountId by calling Identity.change_owner_key. The OwnerKeyChangePermission check will pass because the smith member is not online yet.

Historically, I created a public function, change_owner_key, in the authority-members pallet to update the IdtyIndex -> AccountId association: !86 (diffs).

However, for some reason, the OnIdtyChangeHandler was removed, which introduced a bug.

added C-runtime D-medium ET-weeks I-ToPrioritize bug labels

assigned to @bgallois

mentioned in merge request !319 (merged)

mentioned in commit 5c397510

mentioned in commit c5d6c8e5

mentioned in commit 0dcbcae8

mentioned in commit a07776ad

mentioned in commit 2aa8e03a

mentioned in commit 2fcc5ac0

mentioned in commit 9ea5245c

mentioned in commit 1c2d8b9e

In fact, it is a bit more complicated than that, I think. Let’s say an equivocation offence is committed by Alice, and then she changes her owner key. At this point, there is no longer a direct association between Alice and her previous key.

Some time later, but still within the ReportLongevity period, Bob submits an offence report containing the two conflicting headers and the account id as it was at the time of the offence. Even if the offence is validated, Alice cannot be slashed because her original account is no longer linked to the identity.

We may need to revisit #197 (closed) or apply a period similar to Polkadot's bonding period, where the key cannot be changed before go_offline() + ReportLongevity.

mentioned in commit 7c55b46e

mentioned in commit 95b1f703

mentioned in commit 3d40828c

mentioned in commit 0f23b7d0

closed with merge request !319 (merged)

mentioned in commit 315f93ae