Add RPC method to list peers

Provide an RPC method to list node's libp2p peers.

added C-binary D-medium ET-days P7-nicetohave RN-binary S-ToDo labels

This method exists already:

EDIT: This is an "Unsafe" method.

I think the useful thing to add would be the nodes' addresses, so wallets can discover multiple nodes.

However it should only list nodes with public RPC API, and afaik the client is not aware of this.

afaik the client is not aware of this

This is my understanding as well.

I guess it is possible to use NonDefaultSetConfig in extra_sets to add a network layer that will use the existing connections to gossip RPC addresses.

added S-needdiscussion label

removed D-medium label

removed ET-days label

added D-hard ET-months labels and removed S-ToDo label

After a discussion with @pokapow and @blavenie I'm bumping this issue.

Clients need the ability to discover network and know the nodes they are supposed to connect to.

We need:

• this to be optional so that development nodes do not publish an unstable rpc endpoint
• some kind of trust to avoid an attack by spawning thousands of evil rpc endpoints

We could achieve this with a git repo with gitlab governance but it would be better to have a more flexible approach based on blockchain. In the past elois added a endpoint for smith but that was sketchy and not only smith can provide a RPC mirror (smith nodes should not expose a public rpc endpoint).

mentioned in issue #246 (closed)

removed RN-binary label

added S-ToDo label

I started a branch hugo/endpoint-gossip to see how hard it would be to add a p2p plugin to share endpoint through network and have an offchain worker maintain a list.

assigned to @c-geek

Doing it. https://forum.duniter.org/t/liste-des-endpoints/12347/30?u=cgeek

created branch 97-add-rpc-method-to-list-peers to address this issue

mentioned in merge request !316 (merged)

mentioned in commit ce6bd5b3

mentioned in commit 8ed08060

closed with merge request !316 (merged)

mentioned in commit c95f7831