Replace bool by Result<(), dispatchError> for checks

closes #90 (closed)

added RN-runtime S-doing labels

assigned to @HugoTrentesaux

I'm trying to replace

fn can_create_identity(creator: IdtyIndex) -> bool

by

fn check_create_identity(creator: IdtyIndex) -> Result<(), DispatchError>

However, when adding

#[pallet::error]
    pub enum Error<T> {

to the #[frame_support::pallet] section, I get the error

error: Invalid generic declaration, trait is defined with instance but generic use none
  --> pallets/duniter-wot/src/lib.rs:99:20
   |
99 |     pub enum Error<T> {
   |                    ^

I need to explore more to see how error should be added.

added 1 commit

• 9e8a98cc - wip fix generic type

Compare with previous version

Thanks to a guy on substrate stackexchage (https://substrate.stackexchange.com/questions/4959/invalid-generic-declaration-when-using-frame-macro-palleterror/4960#4960) I fixed it. I just did not know how to use genericity for instantiable pallets.

added 1 commit

• b8b406c5 - wip replace identity confirm check

Compare with previous version

added 1 commit

• 9e7720ce - wip replace identity validation check

Compare with previous version

added 1 commit

• 69ad2193 - wip replace adress change check

Compare with previous version

added 1 commit

• 08beaa33 - wip replace identity removal check

Compare with previous version

added 1 commit

• 8b2548ac - wip replace cert allowed check

Compare with previous version

added 1 commit

• f0dbc0b2 - wip rename check traits

Compare with previous version

added 1 commit

• 2a46c45b - wip merge membership traits

Compare with previous version

added 1 commit

• 40533983 - wip fix tests

Compare with previous version

added 1 commit

• 94a6cdf5 - fix fixme

Compare with previous version

I dealt with all the points listed in the issue. The tests pass. I'm ready for a review.

I replaced "is_***" and "Ensure***" by "check_***" since the result is no more a boolean but a result.

I removed generic error CertNotAllowed for more specific ones (like MaxEmitedCertsReached IssuerCanNotEmitCert CertToUnconfirmedIdty)

changed milestone to %runtime-500

requested review from @librelois

marked this merge request as ready

changed title from Draft: wip try replace identity creation check to Replace bool by Result<(), dispatchError> for checks