Skip to content
Snippets Groups Projects

docker: auto-generate node key file

Merged pini requested to merge pini-docker into master
All threads resolved!
  • Improve docker-entrypoint to auto-generate the node key file when it doesn't exist.
  • Rename variable DUNITER_INSTANCE_NAME to DUNITER_NODE_NAME (the former is still accepted though)
  • Add optional variable DUNITER_PUBLIC_ADDR to configure the '--public-addr' duniter option

Merge request reports

Checking pipeline status.

Approved by

Merged by MoulMoul 2 years ago (Jan 24, 2023 9:03pm UTC)

Merge details

  • Changes merged into master with 585d5807.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • pini added 2 commits

    added 2 commits

    • cdb4fd56 - docker: README.md: fix description
    • 6fc86b06 - docker: telemetry != Prometheus endpoint

    Compare with previous version

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Author Maintainer

    I've started playing with Gitlab CI/CD. It doesn't work great yet, but I was able to upload a Docker image to my DockerHub repository.

    If you want to test the result of this MR use image pinidh/duniter-v2s:test-image-254f2a33.

    EDIT: I have now images pinidh/duniter-v2s:sha-254f2a33 and pinidh/duniter-v2s:sha-latest.

    Edited by pini
  • Author Maintainer

    @HugoTrentesaux What is the status of this MR? I've tested it successfully. The image tagged sha-latest uploaded to my repo is the one that runs on my RPC and validator nodes. Do we need more tests / reviews?

  • pini added 1 commit

    added 1 commit

    Compare with previous version

  • pini marked this merge request as ready

    marked this merge request as ready

  • I think you did good job and that we could merge this without more review. But I would prefer that an other Duniter contributor starts getting interest on maintaining this repo. I'm not a good repo maintainer because I never check carefully enough. I am ok to merge Rust MR's after tuxmain review, but for the Docker / CI parts, I would prefer someone like @1000i100, @moul or @immae.

  • assigned to @pini-gh

  • Moul removed review request for @HugoTrentesaux

    removed review request for @HugoTrentesaux

  • Moul
  • Moul
  • pini added 1 commit

    added 1 commit

    • 72e97149 - docker: use version 3.5 for all compose files

    Compare with previous version

  • pini added 9 commits

    added 9 commits

    • aa02e581 - docker: update docker-compose files
    • e41454c5 - docker: map more environment variables
    • 6f3ded80 - docker: document docker image usage with README.md
    • 6f3288d9 - docker: README.md: add links
    • 0df8f913 - docker: README.md: fix typo
    • 5127aa2a - docker: README.md: fix description
    • 034c3cc7 - docker: telemetry != Prometheus endpoint
    • 11cf9000 - docker: improve README.md
    • 0362d624 - docker: use version 3.5 for all compose files

    Compare with previous version

  • pini requested review from @moul

    requested review from @moul

  • pini assigned to @moul and unassigned @pini-gh

    assigned to @moul and unassigned @pini-gh

  • Je n’ai rien à redire sur l’aspect docker/compose

  • pini added 9 commits

    added 9 commits

    • e5e090e1 - docker: update docker-compose files
    • f98b1100 - docker: map more environment variables
    • 7ac230a4 - docker: document docker image usage with README.md
    • c8f42e08 - docker: README.md: add links
    • d0c21449 - docker: README.md: fix typo
    • d68990db - docker: README.md: fix description
    • 80e1b029 - docker: telemetry != Prometheus endpoint
    • 8259a54d - docker: improve README.md
    • c832d5ea - docker: use version 3.5 for all compose files

    Compare with previous version

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Moul added C-cicd label

    added C-cicd label

  • Moul
  • Moul
  • Moul
  • Moul changed target branch from poka-chainspec to master

    changed target branch from poka-chainspec to master

  • pini added 16 commits

    added 16 commits

    • c832d5ea...3b84a169 - 10 commits from branch master
    • 9c3ff798 - docker: DUNITER_INSTANCE_NAME -> DUNITER_NODE_NAME
    • 35464eab - docker: auto-generate the node key file
    • 68c8731c - docker: variable DUNITER_PUBLIC_ADDR
    • bca46fcd - docker: update docker-compose files
    • bae38a79 - docker: map more environment variables
    • b22e832b - docker: document docker image usage with README.md

    Compare with previous version

  • Author Maintainer

    I've rebased on master and reorganized the commits as requested in the two threads above. Does it look better?

  • Moul resolved all threads

    resolved all threads

  • Yeah, much better for the review. Thanks. I will review the content.

  • Moul resolved all threads

    resolved all threads

  • Moul
  • Moul approved this merge request

    approved this merge request

  • pini added 1 commit

    added 1 commit

    • 585d5807 - docker: document docker image usage with README.md

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • Hugo Trentesaux approved this merge request

    approved this merge request

  • Moul assigned to @pini-gh and unassigned @moul

    assigned to @pini-gh and unassigned @moul

  • Moul
    • Resolved by Moul

      @pini-gh, it seems you do not have the permission to merge it!? You have the developer role on the repository, but, in the settings of the repository only maintainers are allowed to merge on master branch. I can merge it then.

  • Moul resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading