docker: auto-generate node key file
- Improve docker-entrypoint to auto-generate the node key file when it doesn't exist.
- Rename variable DUNITER_INSTANCE_NAME to DUNITER_NODE_NAME (the former is still accepted though)
- Add optional variable DUNITER_PUBLIC_ADDR to configure the '--public-addr' duniter option
Merge request reports
Activity
requested review from @HugoTrentesaux
assigned to @HugoTrentesaux
Resolved by Hugo TrentesauxIt would be nice to add a documentation to tell the user the env var he should set and the job that is done automatically.
- Last reply by pini
assigned to @pini-gh and unassigned @HugoTrentesaux
added 1 commit
- 67c3a704 - docker: document docker image usage with README.md
removed review request for @HugoTrentesaux
requested review from @HugoTrentesaux
assigned to @HugoTrentesaux and unassigned @pini-gh
added 2 commits
- Resolved by Hugo Trentesaux
I added a readme in my documentation branch. You can add
The Docker images are uploaded on https://hub.docker.com/r/duniter/duniter-v2s/tags
and give a bit more detail about this third party service.
Otherwise I'll add when rebasing my branch.
- Last reply by Hugo Trentesaux
- Resolved by Hugo Trentesaux
How can we test this new
docker-entrypoint? - Last reply by pini
unassigned @HugoTrentesaux
I've started playing with Gitlab CI/CD. It doesn't work great yet, but I was able to upload a Docker image to my DockerHub repository.
If you want to test the result of this MR use image
pinidh/duniter-v2s:test-image-254f2a33.EDIT: I have now images
pinidh/duniter-v2s:sha-254f2a33andpinidh/duniter-v2s:sha-latest.Edited by pini@HugoTrentesaux What is the status of this MR? I've tested it successfully. The image tagged
sha-latestuploaded to my repo is the one that runs on my RPC and validator nodes. Do we need more tests / reviews?-
I think you did good job and that we could merge this without more review. But I would prefer that an other Duniter contributor starts getting interest on maintaining this repo. I'm not a good repo maintainer because I never check carefully enough. I am ok to merge Rust MR's after tuxmain review, but for the Docker / CI parts, I would prefer someone like @1000i100, @moul or @immae.
assigned to @pini-gh
removed review request for @HugoTrentesaux
added 1 commit
- 72e97149 - docker: use version 3.5 for all compose files
added 9 commits
- aa02e581 - docker: update docker-compose files
- e41454c5 - docker: map more environment variables
- 6f3ded80 - docker: document docker image usage with README.md
- 6f3288d9 - docker: README.md: add links
- 0df8f913 - docker: README.md: fix typo
- 5127aa2a - docker: README.md: fix description
- 034c3cc7 - docker: telemetry != Prometheus endpoint
- 11cf9000 - docker: improve README.md
- 0362d624 - docker: use version 3.5 for all compose files
Toggle commit listrequested review from @moul
added 9 commits
- e5e090e1 - docker: update docker-compose files
- f98b1100 - docker: map more environment variables
- 7ac230a4 - docker: document docker image usage with README.md
- c8f42e08 - docker: README.md: add links
- d0c21449 - docker: README.md: fix typo
- d68990db - docker: README.md: fix description
- 80e1b029 - docker: telemetry != Prometheus endpoint
- 8259a54d - docker: improve README.md
- c832d5ea - docker: use version 3.5 for all compose files
Toggle commit listadded C-cicd label
added 16 commits
-
c832d5ea...3b84a169 - 10 commits from branch
master - 9c3ff798 - docker: DUNITER_INSTANCE_NAME -> DUNITER_NODE_NAME
- 35464eab - docker: auto-generate the node key file
- 68c8731c - docker: variable DUNITER_PUBLIC_ADDR
- bca46fcd - docker: update docker-compose files
- bae38a79 - docker: map more environment variables
- b22e832b - docker: document docker image usage with README.md
Toggle commit list-
c832d5ea...3b84a169 - 10 commits from branch
