docker: simplify duniter subcommand run
When the first argument of the entrypoint is not an option or is '--' then bypass the default configuration via environment variables and directly run duniter with the given parameters (after removing the first one when it is '--').
The affected scripts and documentation were updated.
Merge request reports
Activity
added RN-silent label
requested review from @HugoTrentesaux
added 2 commits
- Resolved by Hugo Trentesaux
If I understand well:
generate key:
docker run --rm duniter/duniter-v2s:latest key generate
ask for help:
docker run --rm duniter/duniter-v2s:latest -- --help # with additional "--"
We could advise people to add an alias like
dduniter
(for docker duniter) so they can interact with duniter through docker without long commands.If I understand well
You do. The main point is to avoid having to change the entrypoint.
I wonder if it wouldn't be better to use
'--'
for both use cases. What do you think?Edited by pini- Resolved by Hugo Trentesaux
Yes, I think it will be more homogeneous with
--
in both cases.
added 2 commits
added 2 commits
@HugoTrentesaux Am I entitled to merge this MR?
No, I had this MR open in a tab for three days and never had time to review it properly. But in general I prefer that it is not the same person that creates the MR and merge it, it forces more careful review.
I did exceptions for documentation because nobody seemed to want to review them :/
PS: and thanks for rebasing ;)
PPS: merged ^^
Edited by Hugo Trentesauxmentioned in commit b6b77324