Skip to content
Snippets Groups Projects

docker: simplify duniter subcommand run

Merged pini requested to merge pini-docker-entrypoint into master
All threads resolved!

When the first argument of the entrypoint is not an option or is '--' then bypass the default configuration via environment variables and directly run duniter with the given parameters (after removing the first one when it is '--').

The affected scripts and documentation were updated.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • If I understand well:

    generate key:

    docker run --rm duniter/duniter-v2s:latest key generate

    ask for help:

    docker run --rm duniter/duniter-v2s:latest -- --help # with additional "--" 

    We could advise people to add an alias like dduniter (for docker duniter) so they can interact with duniter through docker without long commands.

  • Author Maintainer

    If I understand well

    You do. The main point is to avoid having to change the entrypoint.

    I wonder if it wouldn't be better to use '--' for both use cases. What do you think?

    Edited by pini
  • pini added 1 commit

    added 1 commit

    • 1bb9b0da - docker: simplify duniter subcommand run

    Compare with previous version

  • pini added 2 commits

    added 2 commits

    • f97f5c96 - 1 commit from branch master
    • 2a0d2b69 - docker: simplify duniter subcommand run

    Compare with previous version

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • pini added 2 commits

    added 2 commits

    • e60f55a9 - 1 commit from branch master
    • 1bc2a172 - docker: simplify duniter subcommand run

    Compare with previous version

  • Author Maintainer

    @HugoTrentesaux Am I entitled to merge this MR?

  • No, I had this MR open in a tab for three days and never had time to review it properly. But in general I prefer that it is not the same person that creates the MR and merge it, it forces more careful review.

    I did exceptions for documentation because nobody seemed to want to review them :/

    PS: and thanks for rebasing ;)

    PPS: merged ^^

    Edited by Hugo Trentesaux
  • Hugo Trentesaux approved this merge request

    approved this merge request

  • pini mentioned in commit b6b77324

    mentioned in commit b6b77324

  • Please register or sign in to reply
    Loading