Offences management
All threads resolved!
All threads resolved!
Merge request reports
Activity
assigned to @bgallois
added 1 commit
- 9c9fef7a - feat(pallet_authority_members) add offences execution
changed milestone to %runtime-500
added RN-runtime label
- Add a fork of the Substrate
offences
pallet that is modified to perform the triage of offences from theim_online
,babe
andgrandpa
. Note for future updates that Duniter is not up-to-date with the Substrate offences refactoring, where deprecatedHandleEquivocation
were renamed toEquivocationReportSystem
. - Provides a basic way to process offences:
- On offences from
im-online
pallet, the offenders disconnection are required. - On other offences, the offenders disconnection are required, and offenders are added to a blacklist. Only an authorized origin can remove an offender from this blacklist.
- On offences from
- The offence's triage is realized in the
offences
pallet, and the offence execution is done in theauthority-member
pallet.
Waiting for !155 (merged) to be merged to add the missing benchmark to the
authority-members
pallets.- Add a fork of the Substrate
added 8 commits
-
71bdf3b3...406d5f88 - 5 commits from branch
nodes/rust:master
- d9645adc - feat(pallet_offences) add pallet offences
- 7770c0a6 - feat(pallet_authority_members) add offences execution
- 40be05af - feat(pallet_grandpa) add offences handler
Toggle commit list-
71bdf3b3...406d5f88 - 5 commits from branch
In your implementation of
remove_member_from_blacklist
you perform two binary search:- one to check that the member is actually in the blacklist
- one in the
remove_blacklist
function This is not a big performance issue, but it is not clean either. And I do not see the need to separateremove_blacklist
content from the parentremove_member_from_blacklist
.
added 2 commits
added 2 commits
requested review from @tuxmain
- Resolved by Pascal Engélibert
- Resolved by Benjamin Gallois
- Resolved by Pascal Engélibert
- Resolved by Pascal Engélibert
- Resolved by Benjamin Gallois
added 16 commits
-
b72995ad...5d8ba754 - 7 commits from branch
nodes/rust:master
- f1042a40 - feat(pallet_offences) add pallet offences
- 4c4c4289 - feat(pallet_authority_members) add offences execution
- ab67e51a - feat(pallet_grandpa) add offences handler
- 6c3e3c2c - refac tests
- 429b3075 - add license
- 29f6263e - add missing test
- f312f70d - refactore remove_member_from_blacklist
- 771df7ef - fix slashing strategy
- dc4f80d2 - fix cargo files
Toggle commit list-
b72995ad...5d8ba754 - 7 commits from branch
mentioned in commit dabb2c09
mentioned in issue #26 (closed)
mentioned in issue #27 (closed)
mentioned in issue #94 (closed)
Please register or sign in to reply