refac membership renewal

add expiry unscheduling do not verify expiration block expiring memberships add and refac tests add integration test

pallets/duniter-wot/src/lib.rs

@@ -128,6 +128,7 @@ where
     T: frame_system::Config<AccountId = AccountId> + pallet_membership::Config<I>,
 {
     fn check_create_identity(creator: IdtyIndex) -> Result<(), DispatchError> {
+        // main WoT constraints
         if !T::IsSubWot::get() {
             let cert_meta = pallet_certification::Pallet::<T, I>::idty_cert_meta(creator);
             // perform all checks
@@ -144,9 +145,11 @@ where
                 Error::<T, I>::IdtyCreationPeriodNotRespected
             );
         }
+        // no constraints for subwot
         Ok(())
     }
     fn check_confirm_identity(idty_index: IdtyIndex) -> Result<(), DispatchError> {
+        // main WoT constraints
         if !T::IsSubWot::get() {
             pallet_membership::Pallet::<T, I>::force_request_membership(
                 RawOrigin::Root.into(),
@@ -155,9 +158,11 @@ where
             )
             .map_err(|e| e.error)?;
         }
+        // no constraints for subwot
         Ok(())
     }
     fn check_validate_identity(idty_index: IdtyIndex) -> Result<(), DispatchError> {
+        // main WoT constraints
         if !T::IsSubWot::get() {
             // TODO replace this code by the commented one for distance feature
             /*let idty_cert_meta = pallet_certification::Pallet::<T, I>::idty_cert_meta(idty_index);
@@ -169,18 +174,22 @@ where
             )
             .map_err(|e| e.error)?;
         }
+        // no constraints for subwot
         Ok(())
     }
     fn check_change_identity_address(idty_index: IdtyIndex) -> Result<(), DispatchError> {
+        // sub WoT constraints
         if T::IsSubWot::get() {
             ensure!(
                 !pallet_membership::Pallet::<T, I>::is_member(&idty_index),
                 Error::<T, I>::NotAllowedToChangeIdtyAddress
             );
         }
+        // no constraints for main wot
         Ok(())
     }
     fn check_remove_identity(idty_index: IdtyIndex) -> Result<(), DispatchError> {
+        // identities can not be remove when member of a subwot (smith in this case)
         if T::IsSubWot::get() {
             ensure!(
                 !pallet_membership::Pallet::<T, I>::is_member(&idty_index),