Skip to content
Snippets Groups Projects

Resolve "Identity pallet events are duplicated"

Closed Cédric Moreau requested to merge 115-identity-pallet-events-are-duplicated into master
8 files
+ 101
49
Compare changes
  • Side-by-side
  • Inline
Files
8
@@ -32,7 +32,7 @@ use frame_support::dispatch::UnfilteredDispatchable;
use frame_support::pallet_prelude::*;
use frame_system::RawOrigin;
use pallet_certification::traits::SetNextIssuableOn;
use pallet_identity::{IdtyEvent, IdtyStatus};
use pallet_identity::IdtyStatus;
use sp_runtime::traits::IsMember;
type IdtyIndex = u32;
@@ -300,23 +300,28 @@ where
// implement identity event handler
impl<T: Config<I>, I: 'static> pallet_identity::traits::OnIdtyChange<T> for Pallet<T, I> {
fn on_idty_change(idty_index: IdtyIndex, idty_event: &IdtyEvent<T>) -> Weight {
fn on_idty_change(_idty_index: IdtyIndex, idty_event: &pallet_identity::Event<T>) -> Weight {
let idty_event: pallet_identity::Event<T> = (*idty_event).clone();
match idty_event {
IdtyEvent::Created { creator } => {
pallet_identity::Event::IdtyCreated {
creator,
owner_key: _owner_key,
idty_index,
} => {
if let Err(e) = <pallet_certification::Pallet<T, I>>::do_add_cert_checked(
*creator, idty_index, true,
creator, idty_index, true,
) {
sp_std::if_std! {
println!("fail to force add cert: {:?}", e)
}
}
}
IdtyEvent::Validated => {
pallet_identity::Event::IdtyValidated { idty_index } => {
// auto claim membership on main wot
<pallet_membership::Pallet<T, I>>::try_claim_membership(idty_index);
}
IdtyEvent::Removed { status } => {
if *status != IdtyStatus::Validated {
pallet_identity::Event::IdtyRemoved { idty_index, status } => {
if status != IdtyStatus::Validated {
if let Err(e) =
<pallet_certification::Pallet<T, I>>::remove_all_certs_received_by(
frame_system::Origin::<T>::Root.into(),
@@ -329,7 +334,9 @@ impl<T: Config<I>, I: 'static> pallet_identity::traits::OnIdtyChange<T> for Pall
}
}
}
IdtyEvent::Confirmed | IdtyEvent::ChangedOwnerKey { .. } => {}
pallet_identity::Event::IdtyConfirmed { .. }
| pallet_identity::Event::IdtyChangedOwnerKey { .. }
| pallet_identity::Event::__Ignore(_, _) => {}
}
Weight::zero()
}
Loading