Fix benchmarks

assigned to @bgallois

mentioned in merge request !183 (merged)

C'est super, comme ça ! Merci d'avoir publié ta MR par ce que j'en avais besoin pour benchmarker les quotas dans !183 (merged) et j'étais sur le point de le faire de mon côté ><. Je vais attendre que ce soit prêt et me mettre sur autre chose en attendant :)

added 1 commit

• 500497cf - fix(pallet_identity): fix benchmarks

Compare with previous version

added 1 commit

• 0dd8479b - fix(pallet_membership): fix benchmarks

Compare with previous version

added 2 commits

• 741b15a6 - fix(pallet_membership): fix benchmarks
• 7ac70f92 - refac(benchmark) refactore BenchmarkSetupHandler

Compare with previous version

added RN-runtime label

changed milestone to %runtime-700

Fixed the current benchmarks by:

• Added BenchmarkSetupHandler in the Pallets membership and identity (only required for benchmarks) to circumvent the coupling between wot, distance, membership, certification, and identity.
• Introduced a function in the distance Pallet to enable external manipulation of the distance status, only necessary for benchmarks.
• Implemented the impl_benchmark_setup_handler macro, containing the necessary logic to circumvent the coupling between the Pallets.

This merge request establishes the foundation for moving away from prepared identities required for benchmarks (using gdev-benchmark) by exposing special functions in specific Pallets and employing the impl_benchmark_setup_handler and BenchmarkSetupHandler to bypass Pallet interdependencies during benchmarking.

requested review from @HugoTrentesaux

marked this merge request as ready

resolved all threads

C'est astucieux de faire ça dans un macro et avec des types avec #[cfg(feature = "runtime-benchmarks")]. On dirait que tu n'as pas perdu la main !!

Je valide, merge, on mettra à jour les fichiers weights dans la MR qui fera tout tourner sur RPi. Faudra pas oublier de mettre à jour la date dans le fichier file_header.txt :D

approved this merge request

merged

mentioned in commit fe571d88