Eliminate all Instances of `Weight::zero()`

• Added benchmarks instead of Weight::zero() placeholders.
• Added a missing benchmark in pallet_universal_dividend.
• Regenerated weights for all pallets.
• Added commit f1c396107a2312e5e029a5fe8e36f05234fc2511 to Duniter Substrate to fix pallet_balance WeightInfo.

assigned to @bgallois

added 1 commit

• b6f94294 - fix pallet_identity weight::zero

Compare with previous version

added 1 commit

• af7ecc06 - fix pallet_certification weight::zero

Compare with previous version

added 2 commits

• 6468b67f - fix pallet_authority_members weight::zero
• 0c603e3e - fix pallet_certification weight::zero

Compare with previous version

added 1 commit

• caf9d59d - fix pallet_membership weight::zero

Compare with previous version

added 1 commit

• f1127980 - fix pallet_identity weight::zero

Compare with previous version

added 1 commit

• 82e3f913 - fix pallet_provide_randomness on_initialize weight

Compare with previous version

added 3 commits

• f6beefb9 - fix pallet_identity weight::zero
• 96f1d40e - fix pallet_provide_randomness on_initialize weight
• cc7dd7d7 - update weights

Compare with previous version

requested review from @bgallois

removed review request for @bgallois

added RN-runtime label

changed milestone to %runtime-700

added 2 commits

• 8a5844b9 - update weights
• b885dffa - add missing benchmarks pallet_universal_dividend

Compare with previous version

added 1 commit

• 6048fc08 - add missing benchmarks pallet_universal_dividend

Compare with previous version

added 1 commit

• 4ff55d9a - add hooks benchmark pallet_universal_dividend

Compare with previous version

changed the description

marked this merge request as ready

I think we should define a clear benchmark strategy and apply it to the whole project uniformly. This should include:

• calls (must have benchmark)
• internal functions (has to be defined)
• hooks (compute weights based on their parts)

A documentation page for that would be very welcome. That will help prevent having Weight::zero() spawn in the codebase in the future.

marked this merge request as draft

added 1 commit

• 34661801 - add best practices for benchmarking

Compare with previous version

added 1 commit

• 605274fb - remove handlers weights for pallet_certification

Compare with previous version

added 1 commit

• 2aae3023 - remove handlers weights for pallet_identity

Compare with previous version

added 14 commits

• b356db9a - 1 commit from branch nodes/rust:master
• b356db9a...652a5321 - 3 earlier commits
• 4694bd87 - fix pallet_certification weight::zero
• 520d939e - fix pallet_membership weight::zero
• 8ab552d9 - fix pallet_identity weight::zero
• b4cbca18 - fix pallet_provide_randomness on_initialize weight
• fcc0d9d6 - update weights
• 49e9be0a - add missing benchmarks pallet_universal_dividend
• eed36a0d - add hooks benchmark pallet_universal_dividend
• a8aaa0de - add best practices for benchmarking
• 85ba727d - remove handlers weights for pallet_certification
• ed0fcb4c - remove handlers weights for pallet_identity

Compare with previous version

added 1 commit

• 4beaabaf - remove handlers weights for pallet_membership

Compare with previous version

added 2 commits

• 64221918 - remove handlers weights for pallet_identity
• e02fd02a - remove handlers weights for pallet_membership

Compare with previous version

added 1 commit

• 9d0dea1c - update documentation

Compare with previous version

added 1 commit

• c30f6f9e - fix compilation with runtime-benchmarks flag

Compare with previous version

added 2 commits

• ccae16e4 - fix compilation with runtime-benchmarks feature
• 3810de32 - fix tests with runtime-benchmark feature

Compare with previous version

mentioned in merge request !195 (merged)

added 1 commit

• a4216b5a - refactor functions naming for pallet-certification

Compare with previous version

added 1 commit

• 88fd94c6 - refactor functions naming for pallet-membership

Compare with previous version

added 45 commits

• 88fd94c6...5fa3d533 - 26 commits from branch nodes/rust:master
• 5fa3d533...af1631d6 - 9 earlier commits
• 1643017e - add hooks benchmark pallet_universal_dividend
• 9d806311 - add best practices for benchmarking
• 84cfa057 - remove handlers weights for pallet_certification
• bff58645 - remove handlers weights for pallet_identity
• e7dea368 - remove handlers weights for pallet_membership
• 237947ee - update documentation
• 58cf4521 - fix compilation with runtime-benchmarks feature
• b793f483 - fix tests with runtime-benchmark feature
• 20e4fc6e - refactor functions naming for pallet-certification
• cf556999 - refactor functions naming for pallet-membership

Compare with previous version

added 1 commit

• 080d8417 - refactor functions naming for pallet-membership

Compare with previous version

• Removed handler weights in all pallets.
• Removed unused weight return for internal functions.
• Updated documentation with best practices for benchmarking.
• Fixed runtime compilation with the runtime-benchmarks feature on.
• Fixed tests when run with the runtime-benchmarks feature on.
• Refactored internal function naming from _inner to do_.

CI should pass when !206 (merged) will be merged.

Much cleaner like this! I like your documentation on benchmarks.

Except not sure for do_is_member which is not a functions that "does" something.

Will change it with the membership pallet refactor that should be done at some point. Ready to merge.

Agree, the membership refactoring should be a separate merge request as there will be a lot to do and discuss, I think.

marked this merge request as ready

added 20 commits

• 4389f2ea - 1 commit from branch nodes/rust:master
• 4389f2ea...7b55b83f - 9 earlier commits
• 652e457b - add hooks benchmark pallet_universal_dividend
• 4e1233cd - add best practices for benchmarking
• f7b47ee5 - remove handlers weights for pallet_certification
• 3c169ddd - remove handlers weights for pallet_identity
• 1604e85a - remove handlers weights for pallet_membership
• 2ab81a65 - update documentation
• 8cf965a7 - fix compilation with runtime-benchmarks feature
• 9b02cfb6 - fix tests with runtime-benchmark feature
• 99192fc5 - refactor functions naming for pallet-certification
• 7458ee9e - refactor functions naming for pallet-membership

Compare with previous version

resolved all threads

approved this merge request

added 20 commits

• b4955fa8 - 1 commit from branch nodes/rust:master
• b4955fa8...218c9d3f - 9 earlier commits
• 3745fcee - add hooks benchmark pallet_universal_dividend
• d91602b9 - add best practices for benchmarking
• 541c1c1a - remove handlers weights for pallet_certification
• 166a6c6c - remove handlers weights for pallet_identity
• 3e68aa77 - remove handlers weights for pallet_membership
• 22f2e09a - update documentation
• 2b37de11 - fix compilation with runtime-benchmarks feature
• 5620ee33 - fix tests with runtime-benchmark feature
• 78898195 - refactor functions naming for pallet-certification
• 0fdc934a - refactor functions naming for pallet-membership

Compare with previous version

mentioned in commit cca16dbb

merged

mentioned in issue #154 (closed)

mentioned in issue #128 (closed)