Eliminate all Instances of `Weight::zero()`
- Added benchmarks instead of
Weight::zero()
placeholders. - Added a missing benchmark in
pallet_universal_dividend
. - Regenerated weights for all pallets.
- Added commit f1c396107a2312e5e029a5fe8e36f05234fc2511 to Duniter Substrate to fix
pallet_balance
WeightInfo
.
Edited by Benjamin Gallois
Merge request reports
Activity
Filter activity
assigned to @bgallois
added 1 commit
- 82e3f913 - fix pallet_provide_randomness on_initialize weight
requested review from @bgallois
removed review request for @bgallois
added RN-runtime label
changed milestone to %runtime-700
added 2 commits
added 1 commit
- 6048fc08 - add missing benchmarks pallet_universal_dividend
added 1 commit
- 4ff55d9a - add hooks benchmark pallet_universal_dividend
- Resolved by Hugo Trentesaux
I think we should define a clear benchmark strategy and apply it to the whole project uniformly. This should include:
- calls (must have benchmark)
- internal functions (has to be defined)
- hooks (compute weights based on their parts)
A documentation page for that would be very welcome. That will help prevent having
Weight::zero()
spawn in the codebase in the future.
- Resolved by Hugo Trentesaux
Please register or sign in to reply