Harmonize and document events errors and calls

Refactoring pallets to adhere to the following guidelines:

Call

Custom Duniter pallet calls should adhere to the standard Substrate naming convention:

• action_ for regular calls (e.g., create_identity).
• force_ for calls with a privileged origin (e.g., force_remove_identity).

Error

In the event of a call failure, it should trigger a pallet error with a self-explanatory name, for instance, IdtyNotFound.

Event

Successful calls should deposit a system event to notify external entities of the change. The event name should be self-explanatory and structured in the form of a Rust struct with named fields, ensuring clarity in autogenerated documentation. An example is:

IdtyRemoved {
    idty_index: T::IdtyIndex,
    reason: IdtyRemovalReason<T::IdtyRemovalOtherReason>,
}

Hook

Hooks are inherently infallible, and no errors should be emitted within them. To monitor progression from inside the hook, events can be employed to inform external entities about changes or no-changes.

Internal Function

Internal functions should adhere to the following naming convention:

• do_action for regular functions executing the base logic of a call (e.g., do_remove_identity). These functions should directly emit events and trigger errors as needed.
• force_action for privileged functions that bypass any checks. This can be useful for specific benchmarking functions.
• check_ for functions performing checks and triggering errors in case of failure.

pallets/duniter-wot/src/tests.rs

@@ -83,7 +83,7 @@ fn test_join_smiths() {
             4
         ),));
         System::assert_has_event(RuntimeEvent::SmithMembership(
-            pallet_membership::Event::MembershipRequested(4),
+            pallet_membership::Event::MembershipRequested { member: 4 },
         ));
 
         // Then, Alice should be able to send a smith cert to Dave
@@ -98,7 +98,7 @@ fn test_join_smiths() {
         run_to_block(4);
         assert_ok!(SmithMembership::claim_membership(RuntimeOrigin::signed(4),));
         System::assert_has_event(RuntimeEvent::SmithMembership(
-            pallet_membership::Event::MembershipAcquired(4),
+            pallet_membership::Event::MembershipAcquired { member: 4 },
         ));
     });
 }
@@ -110,7 +110,7 @@ fn test_smith_certs_expirations_should_expire_smith_membership() {
         // After block #10, alice membership should be revoked due to smith certs expiration
         run_to_block(10);
         System::assert_has_event(RuntimeEvent::SmithMembership(
-            pallet_membership::Event::MembershipExpired(1),
+            pallet_membership::Event::MembershipExpired { member: 1 },
         ));
     });
 }
@@ -226,7 +226,7 @@ fn test_new_idty_validation() {
         run_to_block(5);
         assert_ok!(Identity::validate_identity(RuntimeOrigin::signed(42), 6));
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::MembershipAcquired(6),
+            pallet_membership::Event::MembershipAcquired { member: 6 },
         ));
         System::assert_has_event(RuntimeEvent::Identity(
             pallet_identity::Event::IdtyValidated { idty_index: 6 },
@@ -265,7 +265,7 @@ fn test_confirm_idty_ok() {
             IdtyName::from("Ferdie"),
         ));
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::MembershipRequested(6),
+            pallet_membership::Event::MembershipRequested { member: 6 },
         ));
         System::assert_has_event(RuntimeEvent::Identity(
             pallet_identity::Event::IdtyConfirmed {
@@ -349,7 +349,7 @@ fn test_idty_membership_expire() {
         assert!(Membership::membership(3).is_none());
 
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::MembershipExpired(3),
+            pallet_membership::Event::MembershipExpired { member: 3 },
         ));
         // membership expiry should not trigger identity removal
         assert!(!System::events().iter().any(|record| record.event
@@ -365,7 +365,7 @@ fn test_idty_membership_expire() {
         // then pending membership should expire and identity should finally be removed
         run_to_block(11);
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::PendingMembershipExpired(3),
+            pallet_membership::Event::PendingMembershipExpired { member: 3 },
         ));
         System::assert_has_event(RuntimeEvent::Identity(
             pallet_identity::Event::IdtyRemoved {
@@ -453,7 +453,7 @@ fn test_certification_expire() {
         ));
         // in consequence, since Alice has only 1/2 smith certification remaining, she looses smith membership
         System::assert_has_event(RuntimeEvent::SmithMembership(
-            pallet_membership::Event::MembershipExpired(1),
+            pallet_membership::Event::MembershipExpired { member: 1 },
         ));
 
         // --- BLOCK 14 ---
@@ -476,7 +476,7 @@ fn test_certification_expire() {
         ));
         // in consequence, since Alice has only 1/2 normal certification remaining, she looses normal membership
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::MembershipExpired(1),
+            pallet_membership::Event::MembershipExpired { member: 1 },
         ));
 
         // --- BLOCK 21 ---
@@ -502,7 +502,7 @@ fn test_certification_expire() {
         // println!("{:?}", System::events());
         // after a delay (3 blocks), the pending membership finally expires
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::PendingMembershipExpired(1),
+            pallet_membership::Event::PendingMembershipExpired { member: 1 },
         ));
         // and the identity is removed
         System::assert_has_event(RuntimeEvent::Identity(
@@ -565,7 +565,7 @@ fn test_cert_can_not_be_issued() {
         ));
         // in consequence, since Alice has only 1/2 smith certification remaining, she looses smith membership
         System::assert_has_event(RuntimeEvent::SmithMembership(
-            pallet_membership::Event::MembershipExpired(1),
+            pallet_membership::Event::MembershipExpired { member: 1 },
         ));
 
         run_to_block(11);
@@ -613,7 +613,7 @@ fn test_cert_can_not_be_issued() {
         // other certifications expire, but not Dave → Alice
         // in consequence, since Alice has only 1/2 certification remaining, she looses membership
         System::assert_has_event(RuntimeEvent::Membership(
-            pallet_membership::Event::MembershipExpired(1), // pending membership expires at 23
+            pallet_membership::Event::MembershipExpired { member: 1 }, // pending membership expires at 23
         ));
 
         run_to_block(21);