Resolve "srtool no more builds the WASM"
Closes #189 (closed)
Merge request reports
Activity
changed milestone to %runtime-800
added C-runtime P2-asap RN-runtime labels
added 1 commit
- 0173072b - fix(#189 (closed)): add a build step to avoid regression
added 1 commit
- 6ed8d272 - fix(#189 (closed)): force rust-toolchain.toml for runtimes as well
requested review from @bgallois
assigned to @c-geek
- Resolved by Benjamin Gallois
requested review from @HugoTrentesaux and removed review request for @bgallois
changed milestone to %runtime-801
mentioned in issue #189 (closed)
121 when: manual 122 - if: $CI_COMMIT_TAG 123 when: never 124 - if: $CI_COMMIT_BRANCH =~ /^(release\/runtime-)[0-9].*/ 125 when: never 126 - if: '$CI_MERGE_REQUEST_ID || $CI_COMMIT_BRANCH == "master"' 127 - when: manual 128 image: paritytech/srtool:1.74.0-0.13.0 129 variables: 130 PACKAGE: gdev-runtime 131 RUNTIME_DIR: runtime/gdev 132 SRTOOL_OUTPUT: $CI_PROJECT_DIR/release/srtool_output_gdev.json 133 script: 134 - echo "Building runtime for gdev" 135 - mkdir -p $CI_PROJECT_DIR/release 136 - echo -e "[toolchain]\nchannel = \"`curl -s https://raw.githubusercontent.com/paritytech/srtool/master/RUSTC_VERSION`\"\ncomponents = [ \"rust-std\", \"rust-src\" ]" > $RUNTIME_DIR/rust-toolchain.toml # Workaround see !239 I propose a workaround, for the moment, based on the solution found by @c-geek: generating a
rust-toolchain.toml
during the CI process that will match the version normally enforced by srtool.In the meantime, I have opened https://substrate.stackexchange.com/questions/10958/srtool-cli-no-rust-src-error and will be closely monitoring upstream to see if a fix is available (which I think will take a little time).
Edited by Benjamin Gallois
requested review from @HugoTrentesaux
mentioned in commit 1b92a390
mentioned in commit 2d49b03c
mentioned in commit 73000cdd
mentioned in commit 24c0a2ff
mentioned in commit 28befb32
mentioned in commit 3036456c
mentioned in commit 0f671ac6