Change distance evaluation period from Sessions to Blocks

Closes #202 (closed) Closes #207 (closed)

• Create evaluation period in block.
• Update tests.
• Weight accounting
• Upgrade the distance oracle.
• Fix #207 (closed).
• Closes #174 (closed): the worst and simplest estimation equates to one evaluation being 0.0037% of a block's weight, based on the current reference machine. To maintain a reasonable load on the system, it's advisable that the cumulative weight of all evaluations does not surpass 5-10% of a block's capacity. Consequently, setting MAX_EVALUATIONS_PER_SESSION between 1 300 and 2 600 would ensure safe operation.

pallets/distance/src/benchmarking.rs

@@ -20,6 +20,8 @@ use super::*;
 
 use codec::Encode;
 use frame_benchmarking::v2::*;
+use frame_support::traits::Get;
+use frame_support::traits::OnInitialize;
 use frame_support::traits::{Currency, OnFinalize};
 use frame_system::pallet_prelude::BlockNumberFor;
 use frame_system::RawOrigin;
@@ -164,6 +166,103 @@ mod benchmarks {
         assert_has_event::<T>(Event::<T>::EvaluatedValid { idty_index: idty }.into());
     }
 
+    #[benchmark]
+    fn on_initialize_overhead() {
+        // Benchmark on_initialize with no on_finalize and no do_evaluation.
+        let block_number: BlockNumberFor<T> = (T::EvaluationPeriod::get() + 1).into();
+
+        #[block]
+        {
+            Pallet::<T>::on_initialize(block_number);
+        }
+    }
+
+    #[benchmark]
+    fn do_evaluation_success() -> Result<(), BenchmarkError> {
+        // Benchmark do_evaluation in case of one success.
+        CurrentPoolIndex::<T>::put(0);
+        frame_system::pallet::Pallet::<T>::set_block_number(1u32.into());
+        let idty = T::IdtyIndex::one();
+        let caller: T::AccountId = pallet_identity::Identities::<T>::get(idty)
+            .unwrap()
+            .owner_key;
+        let _ =
+            <Balances<T> as Currency<_>>::make_free_balance_be(&caller, T::Balance::max_value());
+        Pallet::<T>::request_distance_evaluation(RawOrigin::Signed(caller.clone()).into())?;
+        assert_has_event::<T>(
+            Event::<T>::EvaluationRequested {
+                idty_index: idty,
+                who: caller.clone(),
+            }
+            .into(),
+        );
+
+        CurrentPoolIndex::<T>::put(2);
+        Pallet::<T>::force_update_evaluation(
+            RawOrigin::Root.into(),
+            caller,
+            ComputationResult {
+                distances: vec![Perbill::one()],
+            },
+        )?;
+
+        #[block]
+        {
+            Pallet::<T>::do_evaluation(0);
+        }
+
+        assert_has_event::<T>(Event::<T>::EvaluatedValid { idty_index: idty }.into());
+        Ok(())
+    }
+
+    #[benchmark]
+    fn do_evaluation_echec() -> Result<(), BenchmarkError> {
+        // Benchmark do_evaluation in case of one echec.
+        CurrentPoolIndex::<T>::put(0);
+        frame_system::pallet::Pallet::<T>::set_block_number(1u32.into());
+        let idty = T::IdtyIndex::one();
+        let caller: T::AccountId = pallet_identity::Identities::<T>::get(idty)
+            .unwrap()
+            .owner_key;
+        let _ =
+            <Balances<T> as Currency<_>>::make_free_balance_be(&caller, T::Balance::max_value());
+        Pallet::<T>::request_distance_evaluation(RawOrigin::Signed(caller.clone()).into())?;
+        assert_has_event::<T>(
+            Event::<T>::EvaluationRequested {
+                idty_index: idty,
+                who: caller.clone(),
+            }
+            .into(),
+        );
+
+        CurrentPoolIndex::<T>::put(2);
+        Pallet::<T>::force_update_evaluation(
+            RawOrigin::Root.into(),
+            caller,
+            ComputationResult {
+                distances: vec![Perbill::zero()],
+            },
+        )?;
+
+        #[block]
+        {
+            Pallet::<T>::do_evaluation(0);
+        }
+
+        assert_has_event::<T>(Event::<T>::EvaluatedInvalid { idty_index: idty }.into());
+        Ok(())
+    }
+
+    #[benchmark]
+    fn do_evaluation_overhead() -> Result<(), BenchmarkError> {
+        #[block]
+        {
+            Pallet::<T>::do_evaluation(0);
+        }
+
+        Ok(())
+    }
+
     #[benchmark]
     fn on_finalize() {
         DidUpdate::<T>::set(true);