Optimize do_remove_all_certs_received_by

• Optimize do_remove_all_certs_received_by by factoring stuff from do_remove_cert
• Fix off-by-one in benchmarking of the call remove_all_certs_received_by (benchmarking was against 1 certification less than the call)

This will reduce the weight of the root call remove_all_certs_received_by and of revocation. Emitted events are the same. A little optimization is still possible, as on_removed is still called N times and checks membership each time (only the last call will revoke membership), but it would require API changes, and the overhead is not that big.

Weights were updated with dummy values, not from benchmarking, so they don't reflect the optimization yet.

Fixes #254 (closed)

pallets/certification/src/benchmarking.rs

@@ -37,11 +37,11 @@ mod benchmarks {
 
     fn add_certs<T: Config>(i: u32, receiver: T::IdtyIndex) -> Result<(), &'static str> {
         Pallet::<T>::remove_all_certs_received_by(RawOrigin::Root.into(), receiver)?;
-        for j in 1..i {
+        for j in 1..i + 1 {
             Pallet::<T>::do_add_cert_checked(j.into(), receiver, false)?;
         }
         assert!(
-            CertsByReceiver::<T>::get(receiver).len() as u32 == i - 1,
+            CertsByReceiver::<T>::get(receiver).len() as u32 == i,
             "Certs not added",
         );
         Ok(())
@@ -157,6 +157,29 @@ mod benchmarks {
         Ok(())
     }
 
+    #[benchmark]
+    fn do_remove_all_certs_received_by(i: Linear<2, 100>) -> Result<(), BenchmarkError> {
+        let receiver: T::IdtyIndex = 0.into();
+        add_certs::<T>(i, receiver)?;
+
+        #[block]
+        {
+            Pallet::<T>::do_remove_all_certs_received_by(receiver);
+        }
+
+        for issuer in 1..i + 1 {
+            assert_has_event::<T>(
+                Event::<T>::CertRemoved {
+                    issuer: issuer.into(),
+                    receiver,
+                    expiration: false,
+                }
+                .into(),
+            );
+        }
+        Ok(())
+    }
+
     impl_benchmark_test_suite!(
         Pallet,
         crate::mock::new_test_ext(crate::mock::DefaultCertificationConfig {