tests(cucumber): add certification

adds certification cucumber test

added 1 commit

• b38e545c - fix(cucumber) clippy and contributing

Compare with previous version

added 51 commits

• b38e545c...364282e5 - 44 commits from branch master
• 4b4578e5 - fix(cucumber) typo in readme
• 22601445 - feat(cucumber) subject agreement
• c0b78efd - feat(cucumber) cert
• 2e3f12ec - fix(cucumber) clippy and contributing
• 0a51f1d4 - doc(cucumber) timeout and caps
• 1fff64de - wip(cucumber) fix broken rebase
• 59a11afd - wip(cucumber) change genesis state

Compare with previous version

@librelois I rebased my branch on master and the certification feature fails with:

Feature: Certification
  Scenario: Dave certifies Alice
   ✘  When dave certifies alice
      Step failed: /home/hugo/dev/duniter-v2s/end2end-tests/cucumber-features/certification.feature:6:9
      Captured output: 
      Step panicked. Captured output: Rpc error: JSON-RPC request error: "{\"jsonrpc\":\"2.0\",\"error\":{\"code\":1010,\"message\":\"Invalid Transaction\",\"data\":\"Inability to pay some fees (e.g. account balance too low)\"},\"id\":5}"

I'm using the wot.json genesis where Dave has 10ĞD which should be enough to pay the transaction fees. So I do not know if this test is supposed to fail.

I'm planning to add new certification scenarios where I test these fees / existential deposit cases.

added 1 commit

• 1b380cce - wip(cucumber) subject agreement in readme

Compare with previous version

added 1 commit

• 00541b0b - fix(cucumber) english correction

Compare with previous version

Also sometimes I get

Feature: Balance transfer
   ✘  Scenario's Before hook failed ./cucumber-features/account_creation.feature:3:3
      Captured output: fail to connect to node: Rpc(Transport(Connection timeout exceeded: 10s))

I'm using DUNITER_END2END_TESTS_SPAWN_NODE_TIMEOUT=60 because otherwise I reach spawn timeout. But this one is different.

added 2 commits

• 0a738727 - wip move duniter typescript to duniter-v2s
• cdae8307 - wip remove irrelevant vscode config

Compare with previous version

added 1 commit

• 07e5c5af - doc(api) add disabled calls

Compare with previous version

added 1 commit

• cf254bc4 - fix(cucumber) bad key for Dave in genesis

Compare with previous version

added 8 commits

• cf254bc4...db18f612 - 7 commits from branch master
• da4b25bf - feat(cucumber) add certification

Compare with previous version

added 1 commit

• 4c76af8d - feat(cucumber) add certification

Compare with previous version

marked this merge request as ready

changed the description

added 1 commit

• 4aa1052f - feat(cucumber): add certification

Compare with previous version

changed title from Hugo cucumber to feat(cucumber): add certification

added 3 commits

• 4aa1052f...fd3746cf - 2 commits from branch master
• 31de4f85 - feat(cucumber): add certification

Compare with previous version

rebased on master

added 4 commits

• 31de4f85...7a438471 - 3 commits from branch master
• 89d0e1fc - feat(cucumber): add certification

Compare with previous version

@librelois on peut merger celle-ci si tu veux. Les tests passent, clippy aussi.

@HugoTrentesaux quand une PR est prête pour review, il faut indiquer @tuxmain ou moi-même pour review. Puis quand l'un de nous deux à fini sa review, il set le reviewer à l'autre.

Je ne savais pas que cette PR était prête pour review, je viens de la review du coup, j'ai 2 remarques bloquantes.

requested review from @tuxmain

requested review from @librelois and removed review request for @tuxmain

requested review from @tuxmain and removed review request for @librelois

added 1 commit

• b2e83cc1 - squash

Compare with previous version

Ah oui, je n'utilisais pas trop ces fonctionnalités de GitLab au labo parce qu'on avait des vraies réunions pour en parler, mais là avec la distance, ça se justifie.

resolved all threads

@HugoTrentesaux je n'ai plus de remarque bloquante sur les diff en elle-même mais ton dernier commit ne respecte pas les conventions git !

added 1 commit

• 1cd5ec31 - feat(cucumber): add certification

Compare with previous version

added 3 commits

• 1cd5ec31...6ac7cbe4 - 2 commits from branch master
• d2c8b1ef - feat(cucumber): add certification

Compare with previous version

@HugoTrentesaux tests are not features. Your commit should have type tests, not feat

Pour celle-ci j'ai dû oublier de pousser, je corrige ça quand je suis sur ma machine ce soir.

added 2 commits

• cac85ff6 - 1 commit from branch master
• 5d65145a - tests(cucumber): add certification

Compare with previous version

changed title from feat(cucumber): add certification to tests(cucumber): add certification

added 1 commit

• c7124d62 - tests(cucumber): improve regex

Compare with previous version

approved this merge request

resolved all threads

added 4 commits

• c7124d62...0e52bc57 - 2 commits from branch master
• b38ebe10 - tests(cucumber): add certification
• 5cc9efe9 - tests(cucumber): improve regex

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for 5cc9efe9 succeeds

mentioned in commit 33630d52

merged