Skip to content
Snippets Groups Projects

build: docker image and compose file

Merged pini requested to merge docker into master
All threads resolved!

Dockerfile, script entrypoint, docker-compose.yml minimaliste.

Edited by pini

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Éloïs
  • Éloïs
  • Éloïs
  • @pini-gh peut tu déplacer tout les fichiers relatifs à docker dans le dossier docker/ stp ? J'aimerais que la racine du dépôt reste relativement clean, merci :)

  • pini added 1 commit

    added 1 commit

    • 7a140461 - build (docker): improve description

    Compare with previous version

  • Moul
  • Moul
  • Author Maintainer

    I am a user of many other dockerized services. And none of them use this workflow you're imposing. They all ship standalone dockerfiles.

    • Resolved by Éloïs

      The question is not here, it's not up to me to find out how to adapt the release workflow to your preferences which are not based on any technical limitation, a dockerfile can be based on an external artifact, it works very well. If you want to bring diffs that need to be done differently to meet the need, it's up to you to figure out how to do it differently and maintain that.

    • Resolved by Éloïs

      My need is that the Dockerfile should build from the source tree. It's a common use case where one makes some changes to the source tree then rebuilds the docker image from there.

      The solution I propose already answers your need: make a script that checks if a file is in build/duniter, and compile from source only if the file in question is not present.

      How about building first the image, then bootstrapping the tests from this image?

      The problem is that we can' t run docker in docker. The only exception is to build a docker image in docker, which we do in a special job using a special image (docker:dind). But we can't use the image produced in a next job of the CI, because the other jobs use another image, which contains all the rust ecosystem and the necessary for the tests.

      I'd like to experiment with gitlab CI to come up with a proper solution.

      I don't care about a "proper" solution, as long as it works and meets the need, and doesn't impact performance, then there's no reason to waste more time, the best is the enemy of the good.

    • Resolved by Éloïs

      Any good reason not to use alpine? Not that I don't want to switch to Debian. I just need to understand why.

      Because the CI jobs use the paritytech/ci-linux image (debian based), maintained by the substrate developers, and which contains everything it does to do CI stuff on a substrate project.

  • pini added 22 commits

    added 22 commits

    • 7a140461...6c8fa3d1 - 9 commits from branch master
    • ba2f63af - build: docker image and compose file
    • 03444d28 - build (docker): configure ports
    • 3fe48985 - build (docker): env var for dev mode and prometheus
    • 37a6f4a2 - build (docker): bump docker-compose version
    • b06abf51 - build (docker): ack name change lc-core -> duniter
    • 7b9c46c1 - build (docker): move docker related files into the docker folder
    • ca52692c - build (docker): use /var/lib/duniter
    • 550c0cb7 - build (docker): variable DUNITER_CHAIN_NAME
    • 55c70397 - build (docker): fix typo in docker-compose file
    • d54f942a - build (docker): improve description
    • ff39a3aa - build (docker): CARGO_PROFILE_RELEASE_LTO="true"
    • 9a5bc3a2 - build (docker): build for Debian buster
    • e2ce2fed - build (docker): build only when no duniter binary

    Compare with previous version

  • Éloïs resolved all threads

    resolved all threads

  • Éloïs
  • pini added 6 commits

    added 6 commits

    • 9e7b55d4 - build (docker): variable DUNITER_CHAIN_NAME
    • 3e27fe7b - build (docker): fix typo in docker-compose file
    • e39fcedb - build (docker): improve description
    • 60199b30 - build (docker): CARGO_PROFILE_RELEASE_LTO="true"
    • d0f77448 - build (docker): build for Debian buster
    • 74bef233 - build (docker): build only when no duniter binary

    Compare with previous version

  • Éloïs resolved all threads

    resolved all threads

  • pini added 20 commits

    added 20 commits

    • 74bef233...fb75bca5 - 7 commits from branch master
    • 3d30108d - build: docker image and compose file
    • 8527dc7e - build (docker): configure ports
    • ae5f0a96 - build (docker): env var for dev mode and prometheus
    • 63dfbc97 - build (docker): bump docker-compose version
    • 6678790d - build (docker): ack name change lc-core -> duniter
    • 4456eb54 - build (docker): move docker related files into the docker folder
    • 8da55ae1 - build (docker): use /var/lib/duniter
    • 931428ab - build (docker): variable DUNITER_CHAIN_NAME
    • 9f5e063e - build (docker): fix typo in docker-compose file
    • 782f772d - build (docker): improve description
    • d42aac05 - build (docker): CARGO_PROFILE_RELEASE_LTO="true"
    • 2f87b413 - build (docker): build for Debian buster
    • ccc97e92 - build (docker): build only when no duniter binary

    Compare with previous version

  • Éloïs
  • pini added 1 commit

    added 1 commit

    • 2b7d6d82 - build (docker): entrypoint: --unsafe-ws-external

    Compare with previous version

  • Éloïs resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading