Remove RevocationPeriod rule

Closes #55 (closed)

added RN-runtime label

changed milestone to %runtime-400

approved this merge request

unapproved this merge request

Thanks you @mildred for your contribution, please remove also the associated error MembershipRevokedRecently and the no longer relevant test.

@mildred If you don't finish your MR I will be forced to finish it for you, please try to finish your first contribution otherwise it is useless.

Sorry, I forgot about it, coming with a new version.

About the tests, should I remove both tests in pallets duniter-wot and membership that mentions revoking membership? There is no longer a revocation period but there is no other test triggering the revocation code either in those pallets.

added 23 commits

• b5b01725...554fe8d2 - 18 commits from branch nodes/rust:master
• fbce116a - Remove RevocationPeriod
• 040f7b17 - Remove RevokedMembership that is always empty
• cf4e13c2 - Remove RevokedMembershipPrunedOn never used
• d32bcbf4 - Remove empty fn prune_revoked_memberships
• fcd17363 - Remove dead code (MembershipRevokedRecently)

Compare with previous version

Well, I suppose you meant removing the test_revoke_smiths_them_rejoin in the duniter-wot pallet as it is the test that was failing, removing it

added 1 commit

• 5578e8f2 - Remove no longer needed test_revoke_smiths_them_rejoin in duniter-wot

Compare with previous version

marked this merge request as ready

approved this merge request

Thank you @mildred for your first contribution, I hope it won't be the last one

merged

mentioned in commit 5159922c

Don't hesitate to ask for me on another issue, I was rather surprised by the slowness of the rust compiler (I didn't remember it like that a few years ago) but that should not really be a problem. Also, sometimes I need to be reminded of things and you did good to ask out after this MR yesterday.