Resolve "Duniter uses a buggy version of TweetNaCl"
Closes #1390 (closed)
Merge request reports
Activity
Filter activity
changed milestone to %1.7
added M-keypair T-bug W-protocol change labels
@c-geek can you review this MR ?
- Resolved by Moul
- Resolved by Moul
- Resolved by Moul
- Resolved by Moul
- Resolved by Moul
Looks great!
I didn’t do a detailed review in the code and I do not have a big picture of the codebase. So, that’s my contribution.
We will anyway try it on Ğ1-test currency.
Edited by Mouladded 11 commits
- 20d4c8de - [ref] rename BLOCK_GENERATED_VERSION -> BLOCK_GENESIS_VERSION
- cc7bb854 - [ref] rename BLOCK_NEW_GENERATED_VERSION -> DUBP_NEXT_VERSION
- eb28e866 - [ref] keyring: add suffix Old to functions sign, signSync and verify
- 4745b85a - [deps] upgrade tweetnacl-js 0.14.3 -> 1.0.1
- 9ab4cd2f - [fix] add new functions sign and verify that use upgraded tweetnacl
- 5c0f103b - [fix] prover: auto use new sign fn when dubp version jump to 12
- 7edd20fc - [fix] block local check: auto use new verify fn when dubp jump to v12
- a8bfba4c - [fix] transactions check: auto use new verify fn when dubp jump to v12
- 15405744 - [tests] wrong block signature should NOT be verified with new verify fn
- c9a89d5d - [feat] automatic transition to dubp version 12
- c9c1a690 - [tests] protocol version jump
Toggle commit listadded 5 commits
- 40e00cd1 - [fix] block local check: auto use new verify fn when dubp jump to v12
- e053d06d - [fix] transactions check: auto use new verify fn when dubp jump to v12
- 2bb98faa - [tests] wrong block signature should NOT be verified with new verify fn
- 750f2204 - [feat] automatic transition to dubp version 12
- 0432787a - [tests] protocol version jump
Toggle commit listadded 9 commits
- 80732437 - [ref] keyring: add suffix Old to functions sign, signSync and verify
- 7a715585 - [deps] upgrade tweetnacl-js 0.14.3 -> 1.0.1
- 693f59a9 - [fix] add new functions sign and verify that use upgraded tweetnacl
- e0fb74fb - [fix] prover: auto use new sign fn when dubp version jump to 12
- 4e9424f4 - [fix] block local check: auto use new verify fn when dubp jump to v12
- 5350a460 - [fix] transactions check: auto use new verify fn when dubp jump to v12
- c908944d - [tests] wrong block signature should NOT be verified with new verify fn
- e3130606 - [feat] automatic transition to dubp version 12
- 1d7b4c63 - [tests] protocol version jump
Toggle commit list- Resolved by Cédric Moreau
added 9 commits
- ad5dc412 - [ref] keyring: add suffix Buggy to functions sign, signSync and verify
- f06cff44 - [deps] upgrade tweetnacl-js 0.14.3 -> 1.0.1
- 51b75d1c - [fix] add new functions sign and verify that use upgraded tweetnacl
- 0c0c8ff5 - [fix] prover: auto use new sign fn when dubp version jump to 12
- 9888ee39 - [fix] block local check: auto use new verify fn when dubp jump to v12
- 45d875a6 - [fix] transactions check: auto use new verify fn when dubp jump to v12
- a479a098 - [tests] wrong block signature should NOT be verified with new verify fn
- 8d639d1e - [feat] automatic transition to dubp version 12
- 811cbbc7 - [tests] protocol version jump
Toggle commit list- Resolved by Cédric Moreau
added 24 commits
-
811cbbc7...3dc2d3a9 - 12 commits from branch
1.7
- 8ac90eac - [ref] rename BLOCK_GENERATED_VERSION -> BLOCK_GENESIS_VERSION
- 218351cd - [ref] rename BLOCK_NEW_GENERATED_VERSION -> DUBP_NEXT_VERSION
- ca53f3d8 - [ref] keyring: add suffix Buggy to functions sign, signSync and verify
- 018e4d1c - [deps] upgrade tweetnacl-js 0.14.3 -> 1.0.1
- d8839e34 - [fix] add new functions sign and verify that use upgraded tweetnacl
- ae64808e - [fix] prover: auto use new sign fn when dubp version jump to 12
- e659d32f - [fix] block local check: auto use new verify fn when dubp jump to v12
- 9885d688 - [fix] transactions check: auto use new verify fn when dubp jump to v12
- 794cb013 - [tests] wrong block signature should NOT be verified with new verify fn
- 3570353b - [feat] automatic transition to dubp version 12
- 4a805871 - [tests] protocol version jump
- 64095c08 - [fix] rebasing: BLOCK_GENERATED_VERSION has been renamed since
Toggle commit list-
811cbbc7...3dc2d3a9 - 12 commits from branch
added 13 commits
-
24bd5270 - 1 commit from branch
1.7
- 64db2c5b - [ref] rename BLOCK_GENERATED_VERSION -> BLOCK_GENESIS_VERSION
- 3df56aaf - [ref] rename BLOCK_NEW_GENERATED_VERSION -> DUBP_NEXT_VERSION
- 6ee4ff25 - [ref] keyring: add suffix Buggy to functions sign, signSync and verify
- 6f8770c6 - [deps] upgrade tweetnacl-js 0.14.3 -> 1.0.1
- e769cd46 - [fix] add new functions sign and verify that use upgraded tweetnacl
- 075bd0d2 - [fix] prover: auto use new sign fn when dubp version jump to 12
- e5884b15 - [fix] block local check: auto use new verify fn when dubp jump to v12
- c3204475 - [fix] transactions check: auto use new verify fn when dubp jump to v12
- 58d97733 - [tests] wrong block signature should NOT be verified with new verify fn
- 1dc7055d - [feat] automatic transition to dubp version 12
- 4df6736e - [tests] protocol version jump
- 850c0a1b - [fix] rebasing: BLOCK_GENERATED_VERSION has been renamed since
Toggle commit list-
24bd5270 - 1 commit from branch
added 7 commits
- 9f7afef8 - [fix] block local check: auto use new verify fn when dubp jump to v12
- 9895862c - [fix] transactions check: auto use new verify fn when dubp jump to v12
- fffa3ebc - [tests] wrong block signature should NOT be verified with new verify fn
- 890fd266 - [feat] automatic transition to dubp version 12
- 4f91525f - [tests] protocol version jump
- 00f753da - [fix] rebasing: BLOCK_GENERATED_VERSION has been renamed since
- 6f6ae5dd - [perf] sign block with buggy nacl for perf & verify sig when found proof
Toggle commit listadded 1 commit
- a617a18a - [perf] sign block with buggy nacl for perf & verify sig when found proof
Please register or sign in to reply