Skip to content
Snippets Groups Projects

#173: Make Transaction multi-sign by default, and add Tx.check_signatures() test on multi-sig tx

Merged #173: Make Transaction multi-sign by default, and add Tx.check_signatures() test on multi-sig tx
All threads resolved!
Merged Moul requested to merge 173_tx_multi_sig into dev
All threads resolved!
  • Make Transaction multi-sign by default

Store SigningKey and Signature arguments/attributes in Lists. Overwrite Document.{sign(),check_signature()} as undefined.

Disable pylint error at Transaction class scope: https://stackoverflow.com/a/22224042 Because of NotImplementedError exception, not happening with Exception


  • Add multi-sig tx test from g1-test tx

Close #173 (closed).

Merge request reports

Merge request pipeline #13059 passed

Merge request pipeline passed for 717b63fb

Approved by

Merged by MoulMoul 3 years ago (Jul 1, 2021 6:31am UTC)

Merge details

Pipeline #13076 waiting for manual action

Pipeline waiting for manual action for 717b63fb on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul
  • Moul added 14 commits

    added 14 commits

    Compare with previous version

  • Moul
  • Moul added 23 commits

    added 23 commits

    Compare with previous version

  • Moul added 1 commit

    added 1 commit

    Compare with previous version

  • Vincent Texier approved this merge request

    approved this merge request

  • Moul resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading